feat(node/tests): fully integrate sysgo into testing framework + CI#2731
feat(node/tests): fully integrate sysgo into testing framework + CI#2731
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates sysgo into the testing framework and adds CI support for running tests with sysgo enabled. The main purpose is to expand the testing infrastructure to support both the existing Kurtosis-based testing and the new sysgo orchestrator.
- Refactors testing structure to separate Kurtosis-specific tests from common tests
- Moves preset configurations to a dedicated package for better organization
- Updates CI workflows to include sysgo-based testing alongside existing Kurtosis tests
Reviewed Changes
Copilot reviewed 29 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/node/sysgo/init_test.go | Creates new test entry point for sysgo testing |
| tests/node/presets/ | Moves and enhances preset configurations to dedicated package |
| tests/node/common/ | Refactors common tests to work with both orchestrators |
| tests/node/kurtosis/ | Isolates Kurtosis-specific test functionality |
| .github/workflows/ | Adds new CI workflow for sysgo tests |
| tests/justfile | Updates build scripts to support both testing modes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // Get artifacts path | ||
| artifactsPath := os.Getenv("OP_DEPLOYER_ARTIFACTS") | ||
| if artifactsPath == "" { | ||
| panic("OP_DEPLOYER_ARTIFACTS is not set") |
There was a problem hiding this comment.
The panic message "OP_DEPLOYER_ARTIFACTS is not set" is not very helpful for users. Consider providing more context about what this environment variable should contain and how to set it properly.
| panic("OP_DEPLOYER_ARTIFACTS is not set") | |
| panic("OP_DEPLOYER_ARTIFACTS is not set. Please set the OP_DEPLOYER_ARTIFACTS environment variable to the path of your contract artifacts directory (e.g., export OP_DEPLOYER_ARTIFACTS=/path/to/artifacts). This directory should contain the deployer contract build outputs required for system setup.") |
ae1f30f to
14b4ea6
Compare
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6b05ed1 to
f59bbaa
Compare
8d9eff1 to
2af5281
Compare
8b77dde to
46591c8
Compare
tests/go.mod
Outdated
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101511.1-dev.1.0.20250608235258-6005dd53e1b5 | ||
|
|
||
| replace github.com/ethereum-optimism/optimism => github.com/theochap/optimism v0.0.0-20250820102920-644504580093 |
There was a problem hiding this comment.
…p-rs/kona#2731) ## Description This PR integrates sysgo inside our testing framework and adds a CI job to ensure all our tests pass with sysgo enabled Reorganizes the e2e test folders. `common` contains tests to run both in sysgo and kurtosis. There are a few kurtosis tests we cannot run in sysgo yet such as: - CPU monitoring tests (doesn't make sense for in-memory mode) - Custom dev websocket tests (cannot access to custom websocket subscriptions through op-node devstack API)
…p-rs/kona#2731) ## Description This PR integrates sysgo inside our testing framework and adds a CI job to ensure all our tests pass with sysgo enabled Reorganizes the e2e test folders. `common` contains tests to run both in sysgo and kurtosis. There are a few kurtosis tests we cannot run in sysgo yet such as: - CPU monitoring tests (doesn't make sense for in-memory mode) - Custom dev websocket tests (cannot access to custom websocket subscriptions through op-node devstack API)
Description
This PR integrates sysgo inside our testing framework and adds a CI job to ensure all our tests pass with sysgo enabled
Reorganizes the e2e test folders.
commoncontains tests to run both in sysgo and kurtosis. There are a few kurtosis tests we cannot run in sysgo yet such as: