chore(sources): remove unused metrics

[theochap]

Description

Unused file

[Copilot]

Pull Request Overview

This pull request removes unused metrics functionality from the sources crate. The PR eliminates the metrics module and its associated dependencies while cleaning up feature flags.

• Removes the entire metrics.rs module containing unused Metrics struct and methods
• Cleans up dependencies and feature flags related to metrics in multiple Cargo.toml files
• Updates import statements by removing the global tracing macro import and adding a specific tracing::info import

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/node/sources/src/metrics.rs	Completely removes the unused metrics module
crates/node/sources/src/lib.rs	Removes metrics module import/export and global tracing macro
crates/node/sources/src/sync/mod.rs	Adds specific tracing::info import
crates/node/sources/Cargo.toml	Removes metrics dependency and feature flag
crates/node/service/Cargo.toml	Removes kona-sources/metrics from metrics feature
crates/node/engine/Cargo.toml	Removes kona-sources/metrics from metrics feature

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[claude]

Claude finished @theochap's task —— View job

---

Code Review Completed ✅

I've completed a thorough review of the PR "chore(sources): remove unused metrics". Here's my comprehensive feedback:

Todo List:

• Read and analyze the deleted metrics.rs file
• Review changes to Cargo.toml files
• Check import changes in lib.rs and sync/mod.rs
• Verify no remaining references to removed metrics
• Provide comprehensive review feedback

Review Feedback

✅ Code Quality & Best Practices

The changes are well-executed and follow good practices:

• Clean removal: The metrics.rs file contained only a simple struct with metric descriptions and initialization code - safe to remove if unused
• Consistent cleanup: All related dependencies and feature flags have been properly removed from multiple Cargo.toml files
• Import optimization: The change from use tracing::* to use tracing::info in sync/mod.rs is more precise and follows best practices

✅ No Potential Bugs or Issues Found

• No remaining references to the removed metrics functionality found in the codebase
• All Cargo.toml changes are consistent and complete
• The RUNTIME_LOADER constant and associated functionality have been completely removed

✅ Performance Considerations

• Positive impact: Removing unused code reduces binary size and compilation time
• Dependency reduction: Eliminated metrics dependency from sources crate reduces the dependency tree
• Import specificity: Using tracing::info instead of tracing::* reduces namespace pollution

✅ Security Concerns

• No security issues identified
• The removed code was simple metrics scaffolding with no security implications
• Changes don't introduce any new attack surface

✅ Test Coverage

• The removed metrics functionality appears to have had no associated tests
• No test updates are needed for this removal
• Existing sync functionality tests remain intact

📋 Summary

This is a well-executed cleanup PR that:

• Removes genuinely unused metrics scaffolding (crates/node/sources/src/metrics.rs:1-26)
• Properly cleans up all related dependencies across 8 files
• Improves import specificity in crates/node/sources/src/sync/mod.rs:13
• Reduces compilation overhead and binary size

Recommendation: ✅ Approve - This is a clean, safe refactoring that improves codebase maintenance.

Note: I was unable to run build commands due to tool permissions, but the static analysis shows no compilation issues should result from these changes.

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.1%. Comparing base (c85425f) to head (db26d72).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.