This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix: Improve registry build script path handling#2672
Merged
clabby merged 5 commits intoop-rs:mainfrom Aug 18, 2025
Merged
Conversation
refcell
approved these changes
Aug 13, 2025
refcell
approved these changes
Aug 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@refcell cargo +nightly fmt --all -- --check ? |
Contributor
Yes it's failing on |
Contributor
Author
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
Refactors the registry build script to use consistent path handling by introducing a variable for the output JSON path. This improves code maintainability and readability by following the same pattern used for other paths in the file, making future modifications easier anle and reduces the risk of errors if the path needs to be modified in the future --------- Co-authored-by: refcell <abigger87@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
Refactors the registry build script to use consistent path handling by introducing a variable for the output JSON path. This improves code maintainability and readability by following the same pattern used for other paths in the file, making future modifications easier anle and reduces the risk of errors if the path needs to be modified in the future --------- Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the registry build script to use consistent path handling by introducing a variable for the output JSON path. This improves code maintainability and readability by following the same pattern used for other paths in the file, making future modifications easier anle and reduces the risk of errors if the path needs to be modified in the future