Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Comments

fix: Improve registry build script path handling#2672

Merged
clabby merged 5 commits intoop-rs:mainfrom
aso20455:main
Aug 18, 2025
Merged

fix: Improve registry build script path handling#2672
clabby merged 5 commits intoop-rs:mainfrom
aso20455:main

Conversation

@aso20455
Copy link
Contributor

@aso20455 aso20455 commented Aug 9, 2025

Refactors the registry build script to use consistent path handling by introducing a variable for the output JSON path. This improves code maintainability and readability by following the same pattern used for other paths in the file, making future modifications easier anle and reduces the risk of errors if the path needs to be modified in the future

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.1%. Comparing base (5fa0a22) to head (496e771).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aso20455
Copy link
Contributor Author

@refcell cargo +nightly fmt --all -- --check ?

@refcell
Copy link
Contributor

refcell commented Aug 14, 2025

@refcell cargo +nightly fmt --all -- --check ?

Yes it's failing on cargo +nightly fmt --all -- --check. Make sure you update your local rust version with rustup update and pull in nightly changes. we have a justfile alias just f that also should work.

@aso20455
Copy link
Contributor Author

@refcell

@clabby clabby added this pull request to the merge queue Aug 18, 2025
Merged via the queue into op-rs:main with commit 75baf65 Aug 18, 2025
33 checks passed
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
Refactors the registry build script to use consistent path handling by
introducing a variable for the output JSON path. This improves code
maintainability and readability by following the same pattern used for
other paths in the file, making future modifications easier anle and
reduces the risk of errors if the path needs to be modified in the
future

---------

Co-authored-by: refcell <abigger87@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Refactors the registry build script to use consistent path handling by
introducing a variable for the output JSON path. This improves code
maintainability and readability by following the same pattern used for
other paths in the file, making future modifications easier anle and
reduces the risk of errors if the path needs to be modified in the
future

---------

Co-authored-by: refcell <abigger87@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants