Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore (supervisor/storage): optimize and rename#2628

Merged
dhyaniarun1993 merged 5 commits intoop-rs:mainfrom
varun-doshi:varun/storage-optimize
Aug 7, 2025
Merged

chore (supervisor/storage): optimize and rename#2628
dhyaniarun1993 merged 5 commits intoop-rs:mainfrom
varun-doshi:varun/storage-optimize

Conversation

@varun-doshi
Copy link
Copy Markdown
Contributor

Fixes #2338

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.8%. Comparing base (665a908) to head (c2166d4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...visor/storage/src/providers/derivation_provider.rs 69.2% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@varun-doshi varun-doshi marked this pull request as ready for review August 1, 2025 19:48
Copilot AI review requested due to automatic review settings August 1, 2025 19:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the latest_derived_block_at_source method in the DerivationProvider to optimize its implementation and improve naming clarity. The change replaces a loop-based traversal with a more efficient cursor-based approach.

Key changes:

  • Renames method from latest_derived_block_at_source to latest_derived_ref_pair_at_source for better clarity
  • Optimizes the traversal algorithm using database cursors instead of manual loop iteration
  • Updates all call sites to use the new method name

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/supervisor/storage/src/providers/derivation_provider.rs Implements optimized cursor-based traversal and renames the method
crates/supervisor/storage/src/chaindb.rs Updates method calls to use the new method name

Copy link
Copy Markdown
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! pending @varun-doshi or @sadiq1971

@dhyaniarun1993 dhyaniarun1993 added this pull request to the merge queue Aug 7, 2025
Merged via the queue into op-rs:main with commit 2227da1 Aug 7, 2025
32 of 34 checks passed
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
Fixes op-rs/kona#2338

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Fixes #2338

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore (supervisor/storage): optimize and rename

4 participants