Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Add observability to rewind progress#2614

Merged
emhane merged 52 commits intoop-rs:mainfrom
JoshdfG:Add-observability-to-rewind-progress
Sep 24, 2025
Merged

Add observability to rewind progress#2614
emhane merged 52 commits intoop-rs:mainfrom
JoshdfG:Add-observability-to-rewind-progress

Conversation

@JoshdfG
Copy link
Copy Markdown
Contributor

@JoshdfG JoshdfG commented Jul 31, 2025 •
edited by emhane
Loading

closes: #2593

Updated incremental percentage for derivation_provider and log_provider
Screenshot 2025-09-24 at 16 57 48
Screenshot 2025-09-24 at 17 05 33

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.21739% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (c2073b4) to head (901146c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/supervisor/storage/src/providers/log_provider.rs 81.6% 9 Missing ⚠️
...visor/storage/src/providers/derivation_provider.rs 87.8% 8 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshdfG JoshdfG force-pushed the Add-observability-to-rewind-progress branch from aad6f0c to 0ae5996 Compare July 31, 2025 22:51
emhane
emhane suggested changes Aug 1, 2025
View reviewed changes
@JoshdfG JoshdfG requested a review from emhane August 1, 2025 19:30
emhane
emhane suggested changes Aug 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add a test that generates this log, see how tracing is enabled in tests

kona/crates/node/sources/src/runtime/loader.rs

Line 178 in 34e4b54

kona_cli::init_test_tracing();

pls screenshot the logs and add picture to description of pr

@JoshdfG @emhane
Update crates/supervisor/storage/src/providers/derivation_provider.rs
f5cdd28 
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
sadiq1971
sadiq1971 reviewed Aug 5, 2025
View reviewed changes
crates/supervisor/storage/src/providers/derivation_provider.rs Outdated
let mut processed_blocks = 0;
const LOG_INTERVAL: u64 = 100;

info!(
Copy link
Copy Markdown
Collaborator

@sadiq1971 sadiq1971 Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to be more specific in which storage the rewinding is being performed.
There is also rewind in the log_provider.rs as well.

emhane
emhane suggested changes Aug 13, 2025
View reviewed changes
crates/supervisor/storage/src/providers/derivation_provider.rs Outdated
let mut cursor = self.tx.cursor_write::<DerivedBlocks>()?;
let mut walker = cursor.walk(Some(block.number))?;
let mut processed_blocks = 0;
const LOG_INTERVAL: u64 = 100;
Copy link
Copy Markdown
Contributor

@emhane emhane Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this interval appropriate @itschaindev or should it be bigger or smaller?

Copy link
Copy Markdown
Collaborator

@itschaindev itschaindev Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be smaller for more granularity. 10 should be good.

Copy link
Copy Markdown
Contributor

@emhane emhane Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

JoshdfG and others added 3 commits August 13, 2025 10:20
@JoshdfG @emhane
Update crates/supervisor/storage/src/providers/derivation_provider.rs
e01404e 
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
@JoshdfG @emhane
Update crates/supervisor/storage/src/providers/derivation_provider.rs
77730b4 
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
@JoshdfG @emhane
Update crates/supervisor/storage/src/providers/derivation_provider.rs
a23b965 
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
@JoshdfG JoshdfG requested a review from sadiq1971 August 13, 2025 17:22
dhyaniarun1993
dhyaniarun1993 reviewed Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dhyaniarun1993 dhyaniarun1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the logic to the log_provider as well?

@JoshdfG JoshdfG requested a review from emhane September 19, 2025 14:14
emhane
emhane suggested changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to apply the review changes to log storage provider too pls

JoshdfG and others added 4 commits September 22, 2025 17:57
@JoshdfG JoshdfG requested a review from emhane September 23, 2025 01:55
emhane
emhane suggested changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the screenshot in the pr description updated?

JoshdfG and others added 3 commits September 23, 2025 02:44
@JoshdfG
Copy link
Copy Markdown
Contributor Author

JoshdfG commented Sep 23, 2025 •
edited
Loading

was the screenshot in the pr description updated?

Done.

@JoshdfG JoshdfG requested a review from emhane September 23, 2025 09:58
@emhane emhane enabled auto-merge September 24, 2025 15:12
@emhane emhane disabled auto-merge September 24, 2025 16:24
@emhane emhane merged commit f314d98 into op-rs:main Sep 24, 2025
38 of 40 checks passed
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@JoshdfG @emhane @dhyaniarun1993
Add observability to rewind progress (op-rs/kona#2614)
a1c5fcf 
closes: op-rs/kona#2593

Updated incremental percentage for derivation_provider and log_provider
<img width="1096" height="119" alt="Screenshot 2025-09-24 at 16 57 48"
src="https://github.com/user-attachments/assets/c0e71e54-97fc-4d97-9ca9-8ad403e3a897"
/>
<img width="1097" height="120" alt="Screenshot 2025-09-24 at 17 05 33"
src="https://github.com/user-attachments/assets/2837e0a9-f2a7-4432-af6c-69a45d8f590d"
/>

---------

Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@JoshdfG @emhane @dhyaniarun1993
Add observability to rewind progress (op-rs/kona#2614)
8a6b110 
closes: #2593

Updated incremental percentage for derivation_provider and log_provider
<img width="1096" height="119" alt="Screenshot 2025-09-24 at 16 57 48"
src="https://github.com/user-attachments/assets/c0e71e54-97fc-4d97-9ca9-8ad403e3a897"
/>
<img width="1097" height="120" alt="Screenshot 2025-09-24 at 17 05 33"
src="https://github.com/user-attachments/assets/2837e0a9-f2a7-4432-af6c-69a45d8f590d"
/>

---------

Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itschaindev itschaindev Awaiting requested review from itschaindev

@clabby clabby Awaiting requested review from clabby

@refcell refcell Awaiting requested review from refcell

@theochap theochap Awaiting requested review from theochap theochap is a code owner

@sadiq1971 sadiq1971 Awaiting requested review from sadiq1971

@dhyaniarun1993 dhyaniarun1993 Awaiting requested review from dhyaniarun1993

@BioMark3r BioMark3r Awaiting requested review from BioMark3r

2 more reviewers

@varun-doshi varun-doshi varun-doshi left review comments

@emhane emhane emhane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

K-observability Kind: related to logs and metrics W-supervisor Workstream: supervisor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add observability to rewind progress

6 participants

@JoshdfG @emhane @itschaindev @sadiq1971 @dhyaniarun1993 @varun-doshi