test(node): connection drop test by theochap · Pull Request #2554 · op-rs/kona

theochap · 2025-07-24T22:04:18Z

Description

Test what happens when the connection to the other nodes of the network drops (or gets cut off from blacklisting)

codecov · 2025-07-24T22:06:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.4%. Comparing base (56d95cf) to head (146c137).
⚠️ Report is 38 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

refcell

These are nice

Copilot

Pull Request Overview

This PR adds comprehensive connection drop tests to verify network behavior when nodes lose connectivity to their peers. The tests simulate connection drops by blacklisting peers and validate synchronization behavior for different node types (sequencers vs non-sequencers).

Adds three new test functions to validate connection drop scenarios
Implements utility functions for stopping/starting Kurtosis services
Fixes function naming inconsistencies in WebSocket helpers

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
tests/node/conn_drops_test.go	New test file implementing connection drop test scenarios
tests/node/mod.go	Adds service start/stop utilities and fixes WebSocket function naming
tests/node/sync_ws_test.go	Updates function calls to use corrected WebSocket helper naming
tests/node/engine_test.go	Removes unused parameter from supportsDevRPC function call

Copilot · 2025-07-25T20:06:26Z

tests/node/mod.go

+		}
+
+		// Stop the service
+		if err := exec.Command("kurtosis", "service", "stop",


Using exec.Command with hardcoded command paths can be a security risk. Consider validating that the 'kurtosis' command exists in PATH and is the expected binary to prevent command injection.

Suggested change

if err := exec.Command("kurtosis", "service", "stop",

kurtosisPath, err := exec.LookPath("kurtosis")

if err != nil {

return fmt.Errorf("kurtosis binary not found in PATH: %w", err)

}

if err := exec.Command(kurtosisPath, "service", "stop",

Copilot · 2025-07-25T20:06:26Z

tests/node/mod.go

+			continue
+		}
+
+		if err := exec.Command("kurtosis", "service", "start",


Using exec.Command with hardcoded command paths can be a security risk. Consider validating that the 'kurtosis' command exists in PATH and is the expected binary to prevent command injection.

Copilot · 2025-07-25T20:06:26Z

tests/node/conn_drops_test.go

+			continue
+		}
+
+		t.Log("testing conn drops for node %s", node.Escape().ID().Key())


The log statement uses printf-style formatting with %s but calls t.Log which doesn't support format specifiers. Use t.Logf instead or remove the format specifier.

Suggested change

t.Log("testing conn drops for node %s", node.Escape().ID().Key())

t.Logf("testing conn drops for node %s", node.Escape().ID().Key())

Copilot · 2025-07-25T20:06:27Z

tests/node/conn_drops_test.go

+			continue
+		}
+
+		t.Log("testing conn drops for node %s", node.Escape().ID().Key())


The log statement uses printf-style formatting with %s but calls t.Log which doesn't support format specifiers. Use t.Logf instead or remove the format specifier.

Suggested change

t.Log("testing conn drops for node %s", node.Escape().ID().Key())

t.Logf("testing conn drops for node %s", node.Escape().ID().Key())

Copilot · 2025-07-25T20:06:27Z

tests/node/conn_drops_test.go

+
+			// Check that the engine task count is correct
+			clRPC, err := GetNodeRPCEndpoint(t.Ctx(), &node)
+			t.Require().NoError(err, "failed to get RPC endpoint for node %s", node.Escape().ID().Key())


The error message uses printf-style formatting with %s but the NoError method may not support format specifiers in this context. Consider using fmt.Sprintf to format the message properly.

Suggested change

t.Require().NoError(err, "failed to get RPC endpoint for node %s", node.Escape().ID().Key())

t.Require().NoError(err, fmt.Sprintf("failed to get RPC endpoint for node %s", node.Escape().ID().Key()))

Copilot · 2025-07-25T20:06:27Z

tests/node/mod.go

 }

+// StopNode stops a specific l2cl node.
+func StopNode(ctx context.Context, node *dsl.L2CLNode) error {


StopNode and StartNode functions have identical logic for service lookup. Consider extracting the common service lookup logic into a helper function to reduce code duplication.

Copilot · 2025-07-25T20:06:27Z

tests/node/mod.go

+// StopKurtosisService stops a specific service in a Kurtosis enclave
+func StopKurtosisService(ctx context.Context, serviceName string) error {


StopKurtosisService and StartKurtosisService have nearly identical implementations with only the command differing. Consider creating a generic function that accepts the action as a parameter to reduce code duplication.

Suggested change

// StopKurtosisService stops a specific service in a Kurtosis enclave

func StopKurtosisService(ctx context.Context, serviceName string) error {

// ManageKurtosisService performs the specified action on a service in a Kurtosis enclave

func ManageKurtosisService(ctx context.Context, serviceName string, action string) error {

theochap · 2025-08-01T15:06:15Z

#2620

## Description This PR adds back the connection drop test and the restart test inside our e2e testing suite See #2554 and #2553

## Description This PR adds back the connection drop test and the restart test inside our e2e testing suite See op-rs/kona#2554 and op-rs/kona#2553

theochap requested review from clabby, dhyaniarun1993, emhane, itschaindev, refcell and sadiq1971 as code owners July 24, 2025 22:04

theochap self-assigned this Jul 24, 2025

theochap added M-tests Meta: Testing related A-node Area: cl node (eq. Go op-node) handles single-chain consensus labels Jul 24, 2025

theochap added this to Project Tracking Jul 24, 2025

theochap moved this to In Review in Project Tracking Jul 24, 2025

theochap added this to the [kona-node] Phase 5: Alpha milestone Jul 24, 2025

theochap force-pushed the theo/restart-test branch from e085998 to adf8e72 Compare July 25, 2025 17:27

theochap force-pushed the theo/conn-drop-test branch from 456cdb7 to 70bb69a Compare July 25, 2025 17:27

theochap force-pushed the theo/restart-test branch 2 times, most recently from 15d28cf to efbb929 Compare July 25, 2025 18:36

theochap force-pushed the theo/conn-drop-test branch from 70bb69a to 6fe1f53 Compare July 25, 2025 18:37

refcell approved these changes Jul 25, 2025

View reviewed changes

theochap force-pushed the theo/restart-test branch from 76e2fa6 to 3542838 Compare July 25, 2025 19:36

theochap changed the base branch from theo/restart-test to main July 25, 2025 20:04

theochap added 3 commits July 25, 2025 16:04

test(node): add restart tests

5ff854c

test(node): add connection drop tests

1114afc

fix(test): removing restart tests

652817b

Copilot AI review requested due to automatic review settings July 25, 2025 20:04

theochap force-pushed the theo/conn-drop-test branch from c4d9de7 to 33b85c5 Compare July 25, 2025 20:04

Copilot AI reviewed Jul 25, 2025

View reviewed changes

theochap force-pushed the theo/conn-drop-test branch 3 times, most recently from 7884e28 to 454551f Compare July 25, 2025 20:58

fix(node/test): fix connection drop test

1c2fc01

theochap force-pushed the theo/conn-drop-test branch from 454551f to 1c2fc01 Compare July 25, 2025 21:09

theochap added 2 commits July 25, 2025 17:12

chore(node/test): unused methods

c615d0f

fix(node/test): fix connection drop test

146c137

theochap force-pushed the theo/conn-drop-test branch from 3124483 to 146c137 Compare July 28, 2025 14:01

theochap mentioned this pull request Aug 1, 2025

test(node): add node restart/connection drop tests once kona is integrated in sysgo #2620

Closed

theochap closed this Aug 1, 2025

github-project-automation bot moved this from In Review to Done in Project Tracking Aug 1, 2025

theochap mentioned this pull request Aug 22, 2025

feat(node/test): connection drop test + restart test #2745

Merged

github-merge-queue bot pushed a commit that referenced this pull request Aug 22, 2025

feat(node/test): connection drop test + restart test (#2745)

4400677

## Description This PR adds back the connection drop test and the restart test inside our e2e testing suite See #2554 and #2553

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

test(node): connection drop test#2554

test(node): connection drop test#2554
theochap wants to merge 6 commits intomainfrom
theo/conn-drop-test

theochap commented Jul 24, 2025

Uh oh!

codecov bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

refcell left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

Copilot AI Jul 25, 2025

Uh oh!

theochap commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-		if err := exec.Command("kurtosis", "service", "stop",
+		kurtosisPath, err := exec.LookPath("kurtosis")
+		if err != nil {
+			return fmt.Errorf("kurtosis binary not found in PATH: %w", err)
+		}
+		if err := exec.Command(kurtosisPath, "service", "stop",

	t.Log("testing conn drops for node %s", node.Escape().ID().Key())
	t.Logf("testing conn drops for node %s", node.Escape().ID().Key())

	t.Require().NoError(err, "failed to get RPC endpoint for node %s", node.Escape().ID().Key())
	t.Require().NoError(err, fmt.Sprintf("failed to get RPC endpoint for node %s", node.Escape().ID().Key()))

		// StopKurtosisService stops a specific service in a Kurtosis enclave
		func StopKurtosisService(ctx context.Context, serviceName string) error {

Comments

Conversation

theochap commented Jul 24, 2025

Description

Uh oh!

codecov bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

refcell left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

theochap commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jul 24, 2025 •

edited

Loading