This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(supervisor/core): added invalidated block on managed node#2541
Merged
itschaindev merged 2 commits intomainfrom Jul 24, 2025
Merged
feat(supervisor/core): added invalidated block on managed node#2541itschaindev merged 2 commits intomainfrom
itschaindev merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds block invalidation functionality to the managed node controller as part of issue #2435. The change enables the supervisor to instruct managed nodes to invalidate blocks when invalid blocks are detected, allowing for proper state rollback.
- Adds
invalidate_blockmethod to theManagedNodeControllertrait - Implements the method across the node client, controller, and related components
- Updates test mocks to include the new invalidation functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/supervisor/core/src/syncnode/traits.rs | Adds invalidate_block method to ManagedNodeController trait with documentation |
| crates/supervisor/core/src/syncnode/node.rs | Implements invalidate_block method in the managed node controller |
| crates/supervisor/core/src/syncnode/client.rs | Adds client-side implementation with RPC call and metrics |
| crates/supervisor/core/src/syncnode/task.rs | Updates mock client to include invalidate_block method |
| crates/supervisor/core/src/syncnode/resetter.rs | Updates mock client to include invalidate_block method |
| crates/supervisor/core/src/chain_processor/task.rs | Updates mock controller to include invalidate_block method |
| crates/supervisor/core/src/chain_processor/chain.rs | Refactors test mocks from manual implementation to mockall-generated mocks |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emhane
approved these changes
Jul 24, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2435