This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Remove deprecated RuntimeActor from kona-node#2535
Merged
Conversation
Co-authored-by: refcell <21288394+refcell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] The RuntimeActor has been deprecated. Can you remove the runtime actor from the
Remove deprecated RuntimeActor from kona-node
Jul 23, 2025
kona-node entirely. Remove the Runtime documentation as well in the docs/ directory.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated RuntimeActor system from the kona-node service, eliminating dynamic runtime configuration management and protocol version signaling functionality. The removal includes all associated components, documentation, and CLI options while maintaining the existing node service architecture.
- Complete removal of RuntimeActor implementation and related state management
- Elimination of runtime configuration loading from L1 contracts
- Removal of protocol version signaling to execution engine via
engine_signalSuperchainV1
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
docs/sidebar.ts |
Removed Runtime navigation link from documentation menu |
docs/docs/pages/node/design/runtime.mdx |
Deleted complete Runtime system documentation |
crates/node/service/src/actors/runtime.rs |
Removed entire RuntimeActor implementation |
crates/node/service/src/actors/mod.rs |
Removed runtime module exports |
crates/node/service/src/lib.rs |
Removed RuntimeActor, RuntimeContext, RuntimeState exports |
crates/node/service/src/service/core.rs |
Removed RuntimeActor trait association and builder method |
crates/node/service/src/service/standard/node.rs |
Removed RuntimeActor type alias and implementation |
crates/node/service/src/service/standard/builder.rs |
Removed runtime load interval configuration |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
## Overview Removes the mention of the `RuntimeActor` from the docs. It was removed in #2535
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
## Description It seems the AI has missed some references in #2535. Removes the remaining runtime libraries in the node.
matrix-rider609op
added a commit
to matrix-rider609op/kona
that referenced
this pull request
Sep 29, 2025
## Description It seems the AI has missed some references in op-rs/kona#2535. Removes the remaining runtime libraries in the node.
aPTRDgvm5ui3dkEtFYWc
added a commit
to aPTRDgvm5ui3dkEtFYWc/kona
that referenced
this pull request
Oct 2, 2025
## Description It seems the AI has missed some references in op-rs/kona#2535. Removes the remaining runtime libraries in the node.
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview This PR completely removes the deprecated `RuntimeActor` from the `kona-node` service, along with all related functionality and documentation as requested in the issue. ## Changes Made ### Removed Files - **`docs/docs/pages/node/design/runtime.mdx`** - Complete Runtime system documentation - **`crates/node/service/src/actors/runtime.rs`** - RuntimeActor implementation ### Modified Files - **`docs/sidebar.ts`** - Removed Runtime link from navigation menu - **`crates/node/service/src/actors/mod.rs`** - Removed runtime module and exports - **`crates/node/service/src/lib.rs`** - Removed RuntimeActor, RuntimeContext, RuntimeState exports - **`crates/node/service/src/service/core.rs`** - Removed RuntimeActor associated type and runtime_builder method from RollupNodeService trait - **`crates/node/service/src/service/standard/node.rs`** - Removed RuntimeActor type alias and runtime_builder implementation - **`crates/node/service/src/service/standard/builder.rs`** - Removed runtime_load_interval field and with_runtime_load_interval method - **`bin/node/src/commands/node.rs`** - Removed `--l1.runtime-config-reload-interval` CLI argument and related functionality ## What Was Removed The RuntimeActor system provided dynamic configuration management and protocol version signaling by: - Monitoring L1 contracts for runtime parameter changes - Fetching configuration from System Config and Protocol Versions contracts - Signaling protocol version updates to the execution engine via `engine_signalSuperchainV1` - Managing periodic configuration reload intervals ## Verification - ✅ `kona-node-service` package compiles successfully - ✅ `kona-node` binary compiles successfully - ✅ All existing unit tests pass (13/13 tests) - ✅ Node binary runs and shows version information correctly - ✅ No breaking changes to existing functionality The removal was surgical and precise, maintaining all existing functionality while cleanly removing the entire deprecated RuntimeActor system. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Removes the mention of the `RuntimeActor` from the docs. It was removed in op-rs/kona#2535
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…rs/kona#2566) ## Description It seems the AI has missed some references in op-rs/kona#2535. Removes the remaining runtime libraries in the node.
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Overview This PR completely removes the deprecated `RuntimeActor` from the `kona-node` service, along with all related functionality and documentation as requested in the issue. ## Changes Made ### Removed Files - **`docs/docs/pages/node/design/runtime.mdx`** - Complete Runtime system documentation - **`crates/node/service/src/actors/runtime.rs`** - RuntimeActor implementation ### Modified Files - **`docs/sidebar.ts`** - Removed Runtime link from navigation menu - **`crates/node/service/src/actors/mod.rs`** - Removed runtime module and exports - **`crates/node/service/src/lib.rs`** - Removed RuntimeActor, RuntimeContext, RuntimeState exports - **`crates/node/service/src/service/core.rs`** - Removed RuntimeActor associated type and runtime_builder method from RollupNodeService trait - **`crates/node/service/src/service/standard/node.rs`** - Removed RuntimeActor type alias and runtime_builder implementation - **`crates/node/service/src/service/standard/builder.rs`** - Removed runtime_load_interval field and with_runtime_load_interval method - **`bin/node/src/commands/node.rs`** - Removed `--l1.runtime-config-reload-interval` CLI argument and related functionality ## What Was Removed The RuntimeActor system provided dynamic configuration management and protocol version signaling by: - Monitoring L1 contracts for runtime parameter changes - Fetching configuration from System Config and Protocol Versions contracts - Signaling protocol version updates to the execution engine via `engine_signalSuperchainV1` - Managing periodic configuration reload intervals ## Verification - ✅ `kona-node-service` package compiles successfully - ✅ `kona-node` binary compiles successfully - ✅ All existing unit tests pass (13/13 tests) - ✅ Node binary runs and shows version information correctly - ✅ No breaking changes to existing functionality The removal was surgical and precise, maintaining all existing functionality while cleanly removing the entire deprecated RuntimeActor system. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…rs/kona#2566) ## Description It seems the AI has missed some references in op-rs/kona#2535. Removes the remaining runtime libraries in the node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR completely removes the deprecated
RuntimeActorfrom thekona-nodeservice, along with all related functionality and documentation as requested in the issue.Changes Made
Removed Files
docs/docs/pages/node/design/runtime.mdx- Complete Runtime system documentationcrates/node/service/src/actors/runtime.rs- RuntimeActor implementationModified Files
docs/sidebar.ts- Removed Runtime link from navigation menucrates/node/service/src/actors/mod.rs- Removed runtime module and exportscrates/node/service/src/lib.rs- Removed RuntimeActor, RuntimeContext, RuntimeState exportscrates/node/service/src/service/core.rs- Removed RuntimeActor associated type and runtime_builder method from RollupNodeService traitcrates/node/service/src/service/standard/node.rs- Removed RuntimeActor type alias and runtime_builder implementationcrates/node/service/src/service/standard/builder.rs- Removed runtime_load_interval field and with_runtime_load_interval methodbin/node/src/commands/node.rs- Removed--l1.runtime-config-reload-intervalCLI argument and related functionalityWhat Was Removed
The RuntimeActor system provided dynamic configuration management and protocol version signaling by:
engine_signalSuperchainV1Verification
kona-node-servicepackage compiles successfullykona-nodebinary compiles successfullyThe removal was surgical and precise, maintaining all existing functionality while cleanly removing the entire deprecated RuntimeActor system.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.