chore(supervisor/core): log improvements in managed node#2526
chore(supervisor/core): log improvements in managed node#2526itschaindev merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging in the managed node system by adding chain ID context to log messages across multiple components. The primary goal is to improve debugging capabilities in multi-chain environments where identifying which chain generated a specific log entry is crucial.
- Adds chain ID parameter to log messages throughout the managed event handling system
- Updates function signatures to accept and propagate chain ID for logging purposes
- Includes chain ID retrieval in resetter operations with performance-conscious caching comments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/supervisor/core/src/syncnode/task.rs | Updates handle_managed_event method to accept chain ID parameter and adds chain ID to all log statements within event handling |
| crates/supervisor/core/src/syncnode/resetter.rs | Adds chain ID retrieval and logging to reset operations and related error handling |
| crates/supervisor/core/src/chain_processor/chain.rs | Includes chain ID in the chain processor start warning log message |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emhane
left a comment
There was a problem hiding this comment.
pls revise all new error logs wrt to comment, otherwise lgtm
Closes #2337