Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(supervisor/core): log improvements in managed node#2526

Merged
itschaindev merged 4 commits intomainfrom
chore/managed-nodelog-cleanup
Jul 24, 2025
Merged

chore(supervisor/core): log improvements in managed node#2526
itschaindev merged 4 commits intomainfrom
chore/managed-nodelog-cleanup

Conversation

@dhyaniarun1993
Copy link
Collaborator

@dhyaniarun1993 dhyaniarun1993 commented Jul 23, 2025

Closes #2337

@dhyaniarun1993 dhyaniarun1993 self-assigned this Jul 23, 2025
Copilot AI review requested due to automatic review settings July 23, 2025 09:54
@dhyaniarun1993 dhyaniarun1993 added the K-chore Kind: chore label Jul 23, 2025
@dhyaniarun1993 dhyaniarun1993 requested a review from theochap as a code owner July 23, 2025 09:54
@dhyaniarun1993 dhyaniarun1993 added the W-supervisor Workstream: supervisor label Jul 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances logging in the managed node system by adding chain ID context to log messages across multiple components. The primary goal is to improve debugging capabilities in multi-chain environments where identifying which chain generated a specific log entry is crucial.

  • Adds chain ID parameter to log messages throughout the managed event handling system
  • Updates function signatures to accept and propagate chain ID for logging purposes
  • Includes chain ID retrieval in resetter operations with performance-conscious caching comments

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/supervisor/core/src/syncnode/task.rs Updates handle_managed_event method to accept chain ID parameter and adds chain ID to all log statements within event handling
crates/supervisor/core/src/syncnode/resetter.rs Adds chain ID retrieval and logging to reset operations and related error handling
crates/supervisor/core/src/chain_processor/chain.rs Includes chain ID in the chain processor start warning log message

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 82.4%. Comparing base (c508d91) to head (ba8802b).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/supervisor/core/src/syncnode/task.rs 50.0% 15 Missing ⚠️
crates/supervisor/core/src/syncnode/resetter.rs 78.5% 6 Missing ⚠️
crates/supervisor/core/src/logindexer/indexer.rs 54.5% 5 Missing ⚠️
...rates/supervisor/core/src/chain_processor/chain.rs 0.0% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls revise all new error logs wrt to comment, otherwise lgtm

Copy link
Collaborator

@itschaindev itschaindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itschaindev itschaindev added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit add9936 Jul 24, 2025
32 of 34 checks passed
@itschaindev itschaindev deleted the chore/managed-nodelog-cleanup branch July 24, 2025 12:45
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-chore Kind: chore W-supervisor Workstream: supervisor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore (supervisor): mention missing chainId in logs

4 participants