Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

test(supervisor): preinterop acceptance test#2463

Merged
dhyaniarun1993 merged 4 commits intomainfrom
feat/preinterop-acceptance-test
Jul 21, 2025
Merged

test(supervisor): preinterop acceptance test#2463
dhyaniarun1993 merged 4 commits intomainfrom
feat/preinterop-acceptance-test

Conversation

@dhyaniarun1993
Copy link
Collaborator

This PR

  • adds the acceptance test for the preinterop which is being skipped as of now due op_contract_deployer_params issues
  • fix the flaky existing test cases

Closes #2272

@dhyaniarun1993 dhyaniarun1993 self-assigned this Jul 21, 2025
@dhyaniarun1993 dhyaniarun1993 added M-tests Meta: Testing related W-supervisor Workstream: supervisor labels Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (9b9a9d3) to head (c529192).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dhyaniarun1993 dhyaniarun1993 marked this pull request as ready for review July 21, 2025 11:24
Copilot AI review requested due to automatic review settings July 21, 2025 11:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds acceptance tests for the pre-interop functionality and fixes flaky existing test cases. The changes consolidate test functions, add comprehensive pre-interop testing (currently skipped due to deployment issues), and enhance post-interop testing with better validation and safety progression checks.

  • Refactors existing test functions to be more modular and reusable
  • Adds new comprehensive acceptance test TestPreNoInbox (currently skipped)
  • Enhances post-interop testing with anchor block validation, safety progression, and interop message inclusion tests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/supervisor/pre_interop/pre_test.go Refactors existing tests into helper functions and adds comprehensive pre-interop acceptance test
tests/supervisor/pre_interop/post_test.go Consolidates post-interop tests and adds comprehensive validation with anchor block and safety progression checks

Copy link
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice workaround

Copy link
Collaborator

@itschaindev itschaindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhyaniarun1993 dhyaniarun1993 added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit e807f1c Jul 21, 2025
44 of 45 checks passed
@dhyaniarun1993 dhyaniarun1993 deleted the feat/preinterop-acceptance-test branch July 21, 2025 13:03
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
This PR
- adds the acceptance test for the preinterop which is being skipped as
of now due `op_contract_deployer_params ` issues
- fix the flaky existing test cases


Closes op-rs/kona#2272
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
This PR
- adds the acceptance test for the preinterop which is being skipped as
of now due `op_contract_deployer_params ` issues
- fix the flaky existing test cases


Closes #2272
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

M-tests Meta: Testing related W-supervisor Workstream: supervisor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(supervisor): preinterop support

4 participants