This repository was archived by the owner on Jan 16, 2026. It is now read-only.
test(supervisor): preinterop acceptance test#2463
Merged
dhyaniarun1993 merged 4 commits intomainfrom Jul 21, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds acceptance tests for the pre-interop functionality and fixes flaky existing test cases. The changes consolidate test functions, add comprehensive pre-interop testing (currently skipped due to deployment issues), and enhance post-interop testing with better validation and safety progression checks.
- Refactors existing test functions to be more modular and reusable
- Adds new comprehensive acceptance test
TestPreNoInbox(currently skipped) - Enhances post-interop testing with anchor block validation, safety progression, and interop message inclusion tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/supervisor/pre_interop/pre_test.go | Refactors existing tests into helper functions and adds comprehensive pre-interop acceptance test |
| tests/supervisor/pre_interop/post_test.go | Consolidates post-interop tests and adds comprehensive validation with anchor block and safety progression checks |
Collaborator
Author
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
This PR - adds the acceptance test for the preinterop which is being skipped as of now due `op_contract_deployer_params ` issues - fix the flaky existing test cases Closes op-rs/kona#2272
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
This PR - adds the acceptance test for the preinterop which is being skipped as of now due `op_contract_deployer_params ` issues - fix the flaky existing test cases Closes #2272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
op_contract_deployer_paramsissuesCloses #2272