Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(supervisor): error consistency#2461

Merged
dhyaniarun1993 merged 3 commits intomainfrom
fix/error-consistency
Jul 21, 2025
Merged

fix(supervisor): error consistency#2461
dhyaniarun1993 merged 3 commits intomainfrom
fix/error-consistency

Conversation

@dhyaniarun1993
Copy link
Copy Markdown
Collaborator

Closes #2278

@dhyaniarun1993 dhyaniarun1993 self-assigned this Jul 21, 2025
@dhyaniarun1993 dhyaniarun1993 added K-fix Kind: fix W-supervisor Workstream: supervisor labels Jul 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.3%. Comparing base (9b9a9d3) to head (b0577b1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/supervisor/core/src/error.rs 66.6% 1 Missing ⚠️
crates/supervisor/storage/src/error.rs 0.0% 1 Missing ⚠️
...visor/storage/src/providers/derivation_provider.rs 91.6% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dhyaniarun1993 dhyaniarun1993 marked this pull request as ready for review July 21, 2025 07:50
Copilot AI review requested due to automatic review settings July 21, 2025 07:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes error handling in the supervisor module by consolidating similar error types and improving naming consistency. The changes aim to resolve issue #2278 by reducing redundancy in error definitions and making the error system more maintainable.

  • Removes redundant error variants (InvalidAnchor, DerivedBlockOutOfOrder) and consolidates them into existing generic variants
  • Renames function parameters from anchor to activation_block/activation_pair for clarity
  • Updates all references and test cases to use the consolidated error types

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
crates/supervisor/storage/src/providers/log_provider.rs Updates parameter naming and error type usage in log provider initialization
crates/supervisor/storage/src/providers/derivation_provider.rs Consolidates error handling and improves parameter naming in derivation provider
crates/supervisor/storage/src/error.rs Removes redundant error variants and simplifies error definitions
crates/supervisor/core/src/error.rs Updates error conversion logic to handle consolidated error types

@dhyaniarun1993 dhyaniarun1993 enabled auto-merge July 21, 2025 11:55
@dhyaniarun1993 dhyaniarun1993 added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@dhyaniarun1993 dhyaniarun1993 merged commit 1cb3431 into main Jul 21, 2025
29 checks passed
@dhyaniarun1993 dhyaniarun1993 deleted the fix/error-consistency branch July 21, 2025 12:13
@dhyaniarun1993
Copy link
Copy Markdown
Collaborator Author

large-kona-tests is failing which is unrelated here. Merging the PR without the check

theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-fix Kind: fix W-supervisor Workstream: supervisor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(supervisor): Consistent error messages

5 participants