fix(supervisor): error consistency#2461
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes error handling in the supervisor module by consolidating similar error types and improving naming consistency. The changes aim to resolve issue #2278 by reducing redundancy in error definitions and making the error system more maintainable.
- Removes redundant error variants (
InvalidAnchor,DerivedBlockOutOfOrder) and consolidates them into existing generic variants - Renames function parameters from
anchortoactivation_block/activation_pairfor clarity - Updates all references and test cases to use the consolidated error types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/supervisor/storage/src/providers/log_provider.rs | Updates parameter naming and error type usage in log provider initialization |
| crates/supervisor/storage/src/providers/derivation_provider.rs | Consolidates error handling and improves parameter naming in derivation provider |
| crates/supervisor/storage/src/error.rs | Removes redundant error variants and simplifies error definitions |
| crates/supervisor/core/src/error.rs | Updates error conversion logic to handle consolidated error types |
|
|
Closes #2278