feat(supervisor/storage): implemented rewinder for log storage#2444
feat(supervisor/storage): implemented rewinder for log storage#2444
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
itschaindev
left a comment
There was a problem hiding this comment.
lgtm. i'll create another ticket in re-org tracker to trigger this so that we don't miss it.
dhyaniarun1993
left a comment
There was a problem hiding this comment.
Also, I think it would be better to perform rewinding based blockID instead of just block number.
| Ok(()) | ||
| } | ||
|
|
||
| pub(crate) fn rewind_from(&self, block_number: u64) -> Result<(), StorageError> { |
There was a problem hiding this comment.
I guess rewind_to name makes more sense considering we are dealing with the append only logging.
I don't think we will need hash matching required here in any case |
But let's do step by step. Will do the change whenever we need it |
Okay. We can do this later. But I think we might need this as an additional consistency check. |
Yes. Specially if we do the rewinding part by part and not in one tx. |
Closes #1837