Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(supervisor/storage): implemented rewinder for log storage#2444

Merged
sadiq1971 merged 5 commits intomainfrom
sa/feat/log-storage-rewind
Jul 21, 2025
Merged

feat(supervisor/storage): implemented rewinder for log storage#2444
sadiq1971 merged 5 commits intomainfrom
sa/feat/log-storage-rewind

Conversation

@sadiq1971
Copy link
Collaborator

Closes #1837

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.2%. Comparing base (9b9a9d3) to head (a8b2dbd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/supervisor/storage/src/chaindb.rs 0.0% 5 Missing ⚠️
...s/supervisor/storage/src/providers/log_provider.rs 95.3% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadiq1971 sadiq1971 self-assigned this Jul 18, 2025
Copy link
Collaborator

@itschaindev itschaindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i'll create another ticket in re-org tracker to trigger this so that we don't miss it.

@sadiq1971 sadiq1971 added this pull request to the merge queue Jul 21, 2025
@sadiq1971 sadiq1971 removed this pull request from the merge queue due to a manual request Jul 21, 2025
Copy link
Collaborator

@dhyaniarun1993 dhyaniarun1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think it would be better to perform rewinding based blockID instead of just block number.

Ok(())
}

pub(crate) fn rewind_from(&self, block_number: u64) -> Result<(), StorageError> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess rewind_to name makes more sense considering we are dealing with the append only logging.

@sadiq1971
Copy link
Collaborator Author

Also, I think it would be better to perform rewinding based blockID instead of just block number.

I don't think we will need hash matching required here in any case

@sadiq1971
Copy link
Collaborator Author

Also, I think it would be better to perform rewinding based blockID instead of just block number.

I don't think we will need hash matching required here in any case

But let's do step by step. Will do the change whenever we need it

@sadiq1971 sadiq1971 requested a review from dhyaniarun1993 July 21, 2025 10:49
@dhyaniarun1993
Copy link
Collaborator

Also, I think it would be better to perform rewinding based blockID instead of just block number.

I don't think we will need hash matching required here in any case

But let's do step by step. Will do the change whenever we need it

Okay. We can do this later. But I think we might need this as an additional consistency check.

@sadiq1971
Copy link
Collaborator Author

Also, I think it would be better to perform rewinding based blockID instead of just block number.

I don't think we will need hash matching required here in any case

But let's do step by step. Will do the change whenever we need it

Okay. We can do this later. But I think we might need this as an additional consistency check.

Yes. Specially if we do the rewinding part by part and not in one tx.

@sadiq1971 sadiq1971 enabled auto-merge July 21, 2025 11:02
@sadiq1971 sadiq1971 added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit 8120fa4 Jul 21, 2025
29 checks passed
@sadiq1971 sadiq1971 deleted the sa/feat/log-storage-rewind branch July 21, 2025 11:35
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(supervisor/storage): L2-reorg: log provider unwinding

3 participants