This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Fix invalid blocks marked as seen#2391
Merged
refcell merged 7 commits intoop-rs:mainfrom Jul 21, 2025
Merged
Conversation
JoshdfG
requested review from
clabby,
emhane,
refcell and
theochap
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
emhane
suggested changes
Jul 15, 2025
emhane
reviewed
Jul 21, 2025
Contributor
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
could also add an assertion that handler.seen_hashes.is_empty() in the test test_invalid_signature
Contributor
Author
done ✅ |
refcell
reviewed
Jul 21, 2025
| signature_bytes[0] = !signature_bytes[0]; | ||
| envelope.signature = Signature::from_raw_array(&signature_bytes).unwrap(); | ||
|
|
||
| assert!(handler.seen_hashes.is_empty()); |
Contributor
There was a problem hiding this comment.
Nice addition to the unit test
refcell
approved these changes
Jul 21, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2361