fix(supervisor/storage): safety head ref initialization

crates/supervisor/storage/src/chaindb.rs

@@ -73,13 +73,7 @@ impl ChainDb {
         self.env.update(|tx| {
             DerivationProvider::new(tx).initialise(anchor)?;
             LogProvider::new(tx).initialise(anchor.derived)?;
-
-            let sp = SafetyHeadRefProvider::new(tx);
-            // todo: cross check if we can consider following safety head ref update
-            sp.update_safety_head_ref(SafetyLevel::LocalUnsafe, &anchor.derived)?;
-            sp.update_safety_head_ref(SafetyLevel::CrossUnsafe, &anchor.derived)?;
-            sp.update_safety_head_ref(SafetyLevel::LocalSafe, &anchor.derived)?;
-            sp.update_safety_head_ref(SafetyLevel::CrossSafe, &anchor.derived)
+            SafetyHeadRefProvider::new(tx).initialise(anchor.derived)
         })?
     }
 }

crates/supervisor/storage/src/providers/head_ref_provider.rs

@@ -43,8 +43,20 @@
 
 impl<Tx> SafetyHeadRefProvider<'_, Tx>
 where
-    Tx: DbTxMut,
+    Tx: DbTxMut + DbTx,
 {
+    pub(crate) fn initialise(&self, anchor: BlockInfo) -> Result<(), StorageError> {
+        match self.get_safety_head_ref(SafetyLevel::LocalUnsafe) {
+            Ok(_) => Ok(()), // if it is set already, skip.
+            Err(StorageError::EntryNotFound(_)) => {
+                self.update_safety_head_ref(SafetyLevel::LocalUnsafe, &anchor)?;
+                self.update_safety_head_ref(SafetyLevel::CrossUnsafe, &anchor)?;
+                self.update_safety_head_ref(SafetyLevel::LocalSafe, &anchor)?;
+                self.update_safety_head_ref(SafetyLevel::CrossSafe, &anchor)
+            }
+            Err(err) => Err(err),
+        }
+    }
     pub(crate) fn update_safety_head_ref(
         &self,
         safety_level: SafetyLevel,