This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Conversation
clabby
requested review from
emhane,
itschaindev,
refcell and
sadiq1971
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
Bumps workspace dependencies to their latest versions, with API and type adjustments to align with updated crates.
- Added
Debugtrait bounds to several generic parameters for enhanced logging and diagnostics. - Refactored block builder code to use
U256for numeric fields and updated blob fee computation patterns. - Updated MPT utils and node logic with unchecked indexing and iterator-based unpacking adjustments.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/proof/proof/src/executor.rs | Added Debug trait bounds on executor generic parameters |
| crates/proof/proof-interop/src/consolidation.rs | Added Debug bound to CommsClient generic parameter |
| crates/proof/mpt/src/util.rs | Switched to from_iter_unchecked and simplified nibble unpacking |
| crates/proof/mpt/src/node.rs | Replaced slice comparisons and indexing with unchecked and to_vec |
| crates/proof/executor/src/builder/env.rs | Converted block number/timestamp to U256 and revamped blob logic |
| crates/proof/executor/src/builder/core.rs | Added Debug bounds and updated log formatting for U256 |
| crates/proof/executor/src/builder/assemble.rs | Used saturating_to::<u64>() for converting U256 fields |
| crates/node/p2p/src/gossip/block_validity.rs | Removed test_block_invalid_base_fee test |
| Cargo.toml | Bumped versions for Alloy, OP Alloy, revm, reth, and other crates |
Comments suppressed due to low confidence (6)
crates/node/p2p/src/gossip/block_validity.rs:656
- The removal of
test_block_invalid_base_feedrops coverage for an important block validity scenario. If behavior has changed, add a replacement test to cover the invalid base fee case.
#[test]
crates/proof/proof/src/executor.rs:58
- [nitpick] The
Debugtrait bound onPdoesn’t appear to be used within the implementation. Consider removing it to avoid unnecessary trait constraints.
P: TrieDBProvider + Debug + Send + Sync + Clone,
crates/proof/proof/src/executor.rs:59
- [nitpick] The
Debugbound onHalso seems unused. Dropping it will simplify the trait requirements if you’re not logging or formattingH.
H: TrieHinter + Debug + Send + Sync + Clone,
crates/proof/proof-interop/src/consolidation.rs:45
- [nitpick] Adding a
Debugbound onCmay be unnecessary if you’re not printing or formatting the client; consider removing it for clarity.
C: CommsClient + Debug + Send + Sync,
crates/proof/mpt/src/util.rs:89
- Calling
rest.to_vec()allocates an intermediateVec<u8>. You could avoid this extra allocation by usingrest.iter().copied()in the chain.
Nibbles::from_iter_unchecked(first.into_iter().chain(rest.to_vec()))
crates/proof/mpt/src/node.rs:163
- Comparing
path.to_vec() == prefix.to_vec()incurs two heap allocations. You can compare slices directly (e.g.path.as_slice() == prefix.as_slice()) to avoid cloning.
Self::Leaf { prefix, value } => Ok((path.to_vec() == prefix.to_vec()).then_some(value)),
304ac9e to
13ad273
Compare
clabby
commented
Jul 6, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_block_invalid_base_fee() { |
Contributor
Author
There was a problem hiding this comment.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Blocked by alloy-rs/nybbles#31 |
clabby
force-pushed
the
cl/bump-deps
branch
2 times, most recently
from
faaa4df to
c12020e
Compare
refcell
reviewed
Jul 7, 2025
| fn handle_gossip_event(&mut self, event: Event) -> Option<OpNetworkPayloadEnvelope> { | ||
| match event { | ||
| Event::Gossipsub(e) => return self.handle_gossipsub_event(e), | ||
| Event::Gossipsub(e) => return self.handle_gossipsub_event(*e), |
Contributor
There was a problem hiding this comment.
We could just pass in a reference here and change the parameter type, but for the sake of keeping this bump pr lean, this is fine
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Bumps the workspace's dependencies.
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Overview Bumps the workspace's dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Bumps the workspace's dependencies.