Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(node/service): Propagated errors raised during NodeActor::start#2322

Merged
theochap merged 1 commit intoop-rs:mainfrom
PoulavBhowmick03:propagate_nodeactor_start_errors
Jul 7, 2025
Merged

feat(node/service): Propagated errors raised during NodeActor::start#2322
theochap merged 1 commit intoop-rs:mainfrom
PoulavBhowmick03:propagate_nodeactor_start_errors

Conversation

@PoulavBhowmick03
Copy link
Contributor

Fixes #2311

Copilot AI review requested due to automatic review settings June 28, 2025 09:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the error propagation mechanism in the NodeActor::start flow by explicitly returning error values from asynchronous tasks.

  • Explicitly returns error values from the error branches in util.rs
  • Updates the start method signature in core.rs to return a Result, propagating error messages

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
crates/node/service/src/service/util.rs Adds explicit error returns in error branches within the macro
crates/node/service/src/service/core.rs Modifies the start method signature and propagates errors via a Result
Comments suppressed due to low confidence (1)

crates/node/service/src/service/util.rs:34

  • Ensure that the error returned in the first branch (line 34) is converted to a String to maintain consistency with the start method signature in core.rs, which expects a Result<(), String>.
                    return Err(e);

@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.0%. Comparing base (273e1aa) to head (7f696eb).
Report is 19 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I will approve this one. As a follow-up it would be great to have a more structured error type to return from start. Potentially an enum we can macro-generate from the actor's list or a dyn Box<...> error type.

@theochap theochap added this pull request to the merge queue Jul 7, 2025
Merged via the queue into op-rs:main with commit b52c150 Jul 7, 2025
25 checks passed
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(node/service): propagate errors raised during NodeActor::start up to the binary level

3 participants