This repository was archived by the owner on Jan 16, 2026. It is now read-only.
chore(node/service): Have EngineActor produce reset request channel#2312
Merged
chore(node/service): Have EngineActor produce reset request channel#2312
EngineActor produce reset request channel#2312Conversation
clabby
added
the
A-node
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the reset request channel so that the EngineActor produces the channel instead of the DerivationActor. The key changes are:
- Removing the reset_request channel from DerivationOutboundChannels.
- Adding the reset_request channel production in EngineActor and updating its outbound data.
- Passing the reset_request_tx to the derivation context from the EngineActor.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/node/service/src/service/core.rs | Adjusts the creation and propagation of the reset_request channel between actors. |
| crates/node/service/src/actors/engine/actor.rs | Implements the reset channel in EngineActor and updates channel handling in actor instantiation. |
| crates/node/service/src/actors/derivation.rs | Removes the reset_request channel from derivation actor and updates related process calls. |
Comments suppressed due to low confidence (1)
crates/node/service/src/actors/derivation.rs:131
- Update the documentation for reset_request_tx to clearly indicate that this sender is now provided externally from the EngineActor and is used for propagating reset events. This clarification will help maintain clarity about the channel's ownership and intended usage.
pub reset_request_tx: mpsc::Sender<()>,
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theochap
approved these changes
Jun 27, 2025
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/kona
that referenced
this pull request
Jun 28, 2025
## Overview Plumbs in the reset request channel from op-rs#2312 into the `SequencerActor`, and sends a reset request if there is a `Reset` error during attributes building. closes op-rs#2305
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…op-rs/kona#2312) ## Overview Inverts the creation of the `reset_request` channel, such that the `EngineActor` produces the channel. This allows for multiple producers to take a handle to the reset request sender in the `RollupNodeService`.
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Overview Plumbs in the reset request channel from op-rs/kona#2312 into the `SequencerActor`, and sends a reset request if there is a `Reset` error during attributes building. closes op-rs/kona#2305
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…op-rs/kona#2312) ## Overview Inverts the creation of the `reset_request` channel, such that the `EngineActor` produces the channel. This allows for multiple producers to take a handle to the reset request sender in the `RollupNodeService`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Inverts the creation of the
reset_requestchannel, such that theEngineActorproduces the channel. This allows for multiple producers to take a handle to the reset request sender in theRollupNodeService.