This repository was archived by the owner on Jan 16, 2026. It is now read-only.
chore(node/rpc): unify RPC actor with the other actors#2308
Merged
Conversation
theochap
added
K-chore
theochap
commented
Jun 26, 2025
Member
Author
There was a problem hiding this comment.
Those variants are not needed anymore. Note that we may be able to do some error handling by propagating the errors from the actors. We can try and do it as a follow-up.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theochap
force-pushed
the
theo/remove-launchers
branch
2 times, most recently
from
9f75322 to
c37a909
Compare
theochap
force-pushed
the
theo/try-simplify-rpc
branch
2 times, most recently
from
0628540 to
12d28d2
Compare
theochap
force-pushed
the
theo/try-simplify-rpc
branch
from
12d28d2 to
5a0bbd1
Compare
refcell
reviewed
Jun 27, 2025
refcell
reviewed
Jun 27, 2025
refcell
reviewed
Jun 27, 2025
refcell
reviewed
Jun 27, 2025
refcell
reviewed
Jun 27, 2025
refcell
reviewed
Jun 27, 2025
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Some smaller comments, overall looks great. Nice consistent pattern
theochap
force-pushed
the
theo/try-simplify-rpc
branch
3 times, most recently
from
4cf7a8f to
cd14ad7
Compare
refcell
reviewed
Jun 27, 2025
theochap
force-pushed
the
theo/try-simplify-rpc
branch
from
cd14ad7 to
a994076
Compare
theochap
force-pushed
the
theo/try-simplify-rpc
branch
from
a994076 to
73d38d9
Compare
theochap
force-pushed
the
theo/try-simplify-rpc
branch
from
73d38d9 to
c91f08b
Compare
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Description This PR refactors the RPC actor in light of op-rs/kona#2303 to unify its interactions with the other actors. Simplifies a little bit the way we handle RPC arguments by removing the `RpcBuilder` and move the `RpcModule` handling inside the `RpcActor`
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Description This PR refactors the RPC actor in light of #2303 to unify its interactions with the other actors. Simplifies a little bit the way we handle RPC arguments by removing the `RpcBuilder` and move the `RpcModule` handling inside the `RpcActor`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the RPC actor in light of #2303 to unify its interactions with the other actors. Simplifies a little bit the way we handle RPC arguments by removing the
RpcBuilderand move theRpcModulehandling inside theRpcActor