chore(node/service): remove process method from NodeActor trait#2266
chore(node/service): remove process method from NodeActor trait#2266
Conversation
There was a problem hiding this comment.
Good start. I think a nice follow-up would be to think about how these Inbound<X>Event enums actually come into play here. Right now they're really just creating an unnecessary (but minimal) memory overhead, for example in the EngineActor where we're Boxing big values to avoid the big enum.
Perhaps rather than a single process method, we just start breaking out individual actions into separate functions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Totally agree, will do! |
…s/kona#2266) ## Description This PR removes the `process` method from `NodeActor` trait to simplify the structure of the `NodeActor` Progress to op-rs/kona#2176
…s/kona#2266) ## Description This PR removes the `process` method from `NodeActor` trait to simplify the structure of the `NodeActor` Progress to #2176
Description
This PR removes the
processmethod fromNodeActortrait to simplify the structure of theNodeActorProgress to #2176