Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(node/service): remove process method from NodeActor trait#2266

Merged
clabby merged 1 commit intomainfrom
theo/remove-process
Jun 24, 2025
Merged

chore(node/service): remove process method from NodeActor trait#2266
clabby merged 1 commit intomainfrom
theo/remove-process

Conversation

@theochap
Copy link
Copy Markdown
Member

@theochap theochap commented Jun 24, 2025

Description

This PR removes the process method from NodeActor trait to simplify the structure of the NodeActor

Progress to #2176

@theochap theochap self-assigned this Jun 24, 2025
Copy link
Copy Markdown
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. I think a nice follow-up would be to think about how these Inbound<X>Event enums actually come into play here. Right now they're really just creating an unnecessary (but minimal) memory overhead, for example in the EngineActor where we're Boxing big values to avoid the big enum.

Perhaps rather than a single process method, we just start breaking out individual actions into separate functions.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.2%. Comparing base (1d2d6d6) to head (4b306cc).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theochap
Copy link
Copy Markdown
Member Author

Good start. I think a nice follow-up would be to think about how these Inbound<X>Event enums actually come into play here. Right now they're really just creating an unnecessary (but minimal) memory overhead, for example in the EngineActor where we're Boxing big values to avoid the big enum.

Perhaps rather than a single process method, we just start breaking out individual actions into separate functions.

Totally agree, will do!

@clabby clabby added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 27f57b8 Jun 24, 2025
24 checks passed
@clabby clabby deleted the theo/remove-process branch June 24, 2025 20:23
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
…s/kona#2266)

## Description

This PR removes the `process` method from `NodeActor` trait to simplify
the structure of the `NodeActor`

Progress to op-rs/kona#2176
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
…s/kona#2266)

## Description

This PR removes the `process` method from `NodeActor` trait to simplify
the structure of the `NodeActor`

Progress to #2176
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants