Conversation
📚
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c7895a to
a9dbc44
Compare
309de99 to
6679f46
Compare
180d8e9 to
5269688
Compare
6679f46 to
9e525f3
Compare
9e525f3 to
da2d355
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Supervisor RPC Server for the kona-node supervisor by introducing a SupervisorExt provider in the node service and integrating new supervisor RPC server logic throughout the codebase.
- Added a SupervisorExt associated type and corresponding accessor in ValidatorNodeService.
- Updated RollupNode to construct and return a supervisor RPC server extension based on SupervisorRpcConfig.
- Introduced new modules and public exports for the supervisor RPC server in the rpc and actors sections and updated Cargo.toml dependencies accordingly.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/node/service/src/service/validator.rs | Added SupervisorExt type and TODO placeholders for supervisor actor integration in the validator service. |
| crates/node/service/src/service/standard/node.rs | Updated RollupNode to include supervisor_rpc configuration and defined supervisor_ext implementation with error handling TODO note. |
| crates/node/service/src/service/standard/builder.rs | Removed an unused attribute and added supervisor_rpc assignment in the node builder. |
| crates/node/service/src/lib.rs | Adjusted imports to include the new SupervisorRpcServerExt. |
| crates/node/service/src/actors/supervisor/* | Added and exported new supervisor RPC server extension types and traits. |
| crates/node/rpc/src/supervisor/*, crates/node/rpc/src/jsonrpsee.rs | Introduced and integrated a new supervisor RPC server implementation and configuration. |
| crates/node/service/Cargo.toml | Added dependency on tokio-stream. |
theochap
left a comment
There was a problem hiding this comment.
Looks good, left a few comments. Most of them are non blocking
### Description Creates an rpc server for the `kona-node` that will service the supervisor. Progress on #2108
### Description Creates an rpc server for the `kona-node` that will service the supervisor. Progress on op-rs/kona#2108
### Description Creates an rpc server for the `kona-node` that will service the supervisor. Progress on #2108
Description
Creates an rpc server for the
kona-nodethat will service the supervisor.Progress on #2108