Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(rpc): Supervisor RPC Server#2162

Merged
refcell merged 6 commits intomainfrom
rf/supervisor-rpc-server
Jun 18, 2025
Merged

feat(rpc): Supervisor RPC Server#2162
refcell merged 6 commits intomainfrom
rf/supervisor-rpc-server

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jun 16, 2025

Description

Creates an rpc server for the kona-node that will service the supervisor.

Progress on #2108

@refcell refcell added the A-protocol Area: protocol crates label Jun 16, 2025
@refcell refcell self-assigned this Jun 16, 2025
@refcell
Copy link
Contributor Author

refcell commented Jun 16, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (6803561) to head (f823e3e).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/rpc/src/supervisor/server.rs 0.0% 44 Missing ⚠️
crates/node/rpc/src/supervisor/config.rs 0.0% 5 Missing ⚠️
crates/node/rpc/src/jsonrpsee.rs 0.0% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@refcell refcell force-pushed the rf/supervisor-init branch from 6c7895a to a9dbc44 Compare June 16, 2025 21:00
@refcell refcell force-pushed the rf/supervisor-rpc-server branch 3 times, most recently from 309de99 to 6679f46 Compare June 16, 2025 22:21
@refcell refcell force-pushed the rf/supervisor-init branch from 180d8e9 to 5269688 Compare June 17, 2025 16:42
@refcell refcell force-pushed the rf/supervisor-rpc-server branch from 6679f46 to 9e525f3 Compare June 17, 2025 16:42
Base automatically changed from rf/supervisor-init to main June 17, 2025 17:17
@refcell refcell force-pushed the rf/supervisor-rpc-server branch from 9e525f3 to da2d355 Compare June 17, 2025 17:24
@refcell refcell marked this pull request as ready for review June 17, 2025 18:36
Copilot AI review requested due to automatic review settings June 17, 2025 18:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new Supervisor RPC Server for the kona-node supervisor by introducing a SupervisorExt provider in the node service and integrating new supervisor RPC server logic throughout the codebase.

  • Added a SupervisorExt associated type and corresponding accessor in ValidatorNodeService.
  • Updated RollupNode to construct and return a supervisor RPC server extension based on SupervisorRpcConfig.
  • Introduced new modules and public exports for the supervisor RPC server in the rpc and actors sections and updated Cargo.toml dependencies accordingly.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/node/service/src/service/validator.rs Added SupervisorExt type and TODO placeholders for supervisor actor integration in the validator service.
crates/node/service/src/service/standard/node.rs Updated RollupNode to include supervisor_rpc configuration and defined supervisor_ext implementation with error handling TODO note.
crates/node/service/src/service/standard/builder.rs Removed an unused attribute and added supervisor_rpc assignment in the node builder.
crates/node/service/src/lib.rs Adjusted imports to include the new SupervisorRpcServerExt.
crates/node/service/src/actors/supervisor/* Added and exported new supervisor RPC server extension types and traits.
crates/node/rpc/src/supervisor/*, crates/node/rpc/src/jsonrpsee.rs Introduced and integrated a new supervisor RPC server implementation and configuration.
crates/node/service/Cargo.toml Added dependency on tokio-stream.

Copy link
Member

@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments. Most of them are non blocking

@refcell refcell added this pull request to the merge queue Jun 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 18, 2025
@refcell refcell added this pull request to the merge queue Jun 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 18, 2025
@refcell refcell added this pull request to the merge queue Jun 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 18, 2025
@refcell refcell merged commit 233afa9 into main Jun 18, 2025
22 of 24 checks passed
@refcell refcell deleted the rf/supervisor-rpc-server branch June 18, 2025 12:24
theochap pushed a commit that referenced this pull request Jun 18, 2025
### Description

Creates an rpc server for the `kona-node` that will service the
supervisor.

Progress on #2108
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
### Description

Creates an rpc server for the `kona-node` that will service the
supervisor.

Progress on op-rs/kona#2108
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
### Description

Creates an rpc server for the `kona-node` that will service the
supervisor.

Progress on #2108
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-protocol Area: protocol crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants