Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(node): Standardize envvars#2114

Merged
refcell merged 1 commit intomainfrom
cl/standard-envvars
Jun 12, 2025
Merged

chore(node): Standardize envvars#2114
refcell merged 1 commit intomainfrom
cl/standard-envvars

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Jun 11, 2025

Overview

Standardizes the envvar prefix for all kona-node CLI options.

Also adds the KONA_ prefix for the global metrics args.

@clabby clabby self-assigned this Jun 11, 2025
@clabby clabby requested review from emhane and refcell as code owners June 11, 2025 23:49
@clabby clabby added the K-chore Kind: chore label Jun 11, 2025
@clabby clabby requested a review from theochap as a code owner June 11, 2025 23:49
@clabby clabby added A-node Area: cl node (eq. Go op-node) handles single-chain consensus W-node Workstream: kona-node A-cli Area: CLI labels Jun 11, 2025
Base automatically changed from cl/l2-chain-id-env to main June 12, 2025 00:28
@clabby clabby force-pushed the cl/standard-envvars branch from 8cbf6a5 to 85d79e7 Compare June 12, 2025 00:29
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.4%. Comparing base (b8feab4) to head (85d79e7).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clabby clabby added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 12, 2025
@refcell refcell added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@refcell refcell added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 151b711 Jun 12, 2025
24 checks passed
@refcell refcell deleted the cl/standard-envvars branch June 12, 2025 13:00
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2025
## Overview

Missed one in #2114; Adds an envvar for the rollup config.

Co-authored-by: refcell <abigger87@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Overview

Standardizes the envvar prefix for all kona-node CLI options.

Also adds the `KONA_` prefix for the global metrics args.
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Overview

Missed one in op-rs/kona#2114; Adds an envvar for the rollup config.

Co-authored-by: refcell <abigger87@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
## Overview

Standardizes the envvar prefix for all kona-node CLI options.

Also adds the `KONA_` prefix for the global metrics args.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-cli Area: CLI A-node Area: cl node (eq. Go op-node) handles single-chain consensus K-chore Kind: chore W-node Workstream: kona-node

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants