This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Conversation
Contributor
Author
📚
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Sets up initial metrics support for the kona-derive pipeline.
- Marks the macros crate as
no_std - Defines metric identifiers and an init/describe/zero API
- Instruments the L1 traversal stage and adds a
metricsfeature with optional dependency
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/utilities/macros/src/lib.rs | Added #![no_std] |
| crates/protocol/derive/src/stages/l1_traversal.rs | Added update_origin, inc! and timing instrumentation |
| crates/protocol/derive/src/metrics/mod.rs | New Metrics struct with constants and init/describe/zero API |
| crates/protocol/derive/src/lib.rs | Conditional no_std and exposed metrics module |
| crates/protocol/derive/Cargo.toml | Added optional metrics dependency and feature |
Comments suppressed due to low confidence (3)
crates/protocol/derive/src/metrics/mod.rs:19
- The doc comment refers to the P2P stack but this is for the derivation pipeline. Update the comment to accurately describe its scope.
/// Initializes metrics for the P2P stack.
crates/protocol/derive/src/stages/l1_traversal.rs:79
- New metric recording logic is not covered by existing tests; consider adding tests to verify that metrics are initialized and recorded correctly under the
metricsfeature.
#[cfg(feature = "metrics")]
crates/utilities/macros/src/lib.rs:9
- [nitpick] Applying
#![no_std]unconditionally may prevent macros that rely onstdfrom compiling. Consider conditionally enablingno_stdbased on a feature.
#![no_std]
This was referenced Jun 4, 2025
clabby
reviewed
Jun 4, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
### Description Sets up the first set of metrics for `kona-derive`. Closes op-rs/kona#1981 Closes op-rs/kona#1982
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
### Description Sets up the first set of metrics for `kona-derive`. Closes #1981 Closes #1982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets up the first set of metrics for
kona-derive.Closes #1981
Closes #1982