Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(mpt): Do not expose recursion vars#197

Merged
clabby merged 1 commit intomainfrom
cl/hide-recursive-params
Jun 4, 2024
Merged

chore(mpt): Do not expose recursion vars#197
clabby merged 1 commit intomainfrom
cl/hide-recursive-params

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Jun 1, 2024

Overview

Hides the recursive variable in TrieNode::insert and TrieNode::open

Copy link
Contributor Author

clabby commented Jun 1, 2024

@clabby clabby mentioned this pull request Jun 1, 2024
@clabby clabby force-pushed the cl/hide-recursive-params branch from 846b8a5 to 5573789 Compare June 1, 2024 01:51
@clabby clabby marked this pull request as draft June 1, 2024 01:55
@clabby clabby self-assigned this Jun 1, 2024
@clabby clabby added K-chore Kind: chore A-mpt labels Jun 1, 2024
@clabby clabby mentioned this pull request Jun 1, 2024
@clabby clabby force-pushed the cl/trie-db-commit branch from 3e11d2e to d6c8369 Compare June 1, 2024 22:05
@clabby clabby force-pushed the cl/hide-recursive-params branch from 5573789 to 92f9394 Compare June 1, 2024 22:05
@clabby clabby marked this pull request as ready for review June 1, 2024 22:06
@clabby clabby force-pushed the cl/hide-recursive-params branch from 92f9394 to 2901cba Compare June 1, 2024 22:09
@clabby clabby force-pushed the cl/trie-db-commit branch from d6c8369 to 557784b Compare June 1, 2024 22:27
@clabby clabby force-pushed the cl/hide-recursive-params branch from 2901cba to 3dbcf50 Compare June 1, 2024 22:27
@clabby clabby requested a review from refcell June 2, 2024 05:53
@clabby clabby force-pushed the cl/trie-db-commit branch from 557784b to 3169166 Compare June 3, 2024 22:50
@clabby clabby force-pushed the cl/hide-recursive-params branch from 3dbcf50 to c349b63 Compare June 3, 2024 22:50
@clabby clabby force-pushed the cl/trie-db-commit branch from 3169166 to 9dd36ee Compare June 3, 2024 22:56
@clabby clabby force-pushed the cl/hide-recursive-params branch from c349b63 to 9ff3949 Compare June 3, 2024 22:56
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor ✅

Base automatically changed from cl/trie-db-commit to main June 4, 2024 15:12
Hides the recursive variable in `TrieNode::insert` and `TrieNode::open`
@clabby clabby force-pushed the cl/hide-recursive-params branch from 9ff3949 to ff35886 Compare June 4, 2024 15:12
@clabby clabby enabled auto-merge June 4, 2024 15:13
@clabby clabby added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 7e4d948 Jun 4, 2024
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 11, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
@clabby clabby deleted the cl/hide-recursive-params branch July 2, 2024 03:37
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
Hides the recursive variable in `TrieNode::insert` and `TrieNode::open`
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Hides the recursive variable in `TrieNode::insert` and `TrieNode::open`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-chore Kind: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants