This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Supervisor handling node updates via subscription#1836
Merged
dhyaniarun1993 merged 27 commits intomainfrom May 26, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
itschaindev
requested review from
clabby,
dhyaniarun1993,
emhane,
refcell,
sadiq1971 and
theochap
as code owners
emhane
suggested changes
May 23, 2025
| |_| { | ||
| use std::io::Write; | ||
| let secret = JwtSecret::random(); | ||
| if let Ok(mut file) = File::create("jwt.hex") { |
Collaborator
There was a problem hiding this comment.
I don't think we should create the jwt here.
Since we are developing the client side, we shouldn't create the jwt(The should be the server's responsibility).
| let auth_header = | ||
| format!("Bearer {}", alloy_primitives::hex::encode(jwt_secret.as_bytes())); | ||
| headers.insert( | ||
| "Authorization", |
Collaborator
Author
There was a problem hiding this comment.
which crate are you referring to here?
Comment on lines
+241
to
+242
| let err_msg = format!("Failed to send stop signal: {:?}", e); | ||
| error!("{}", err_msg); |
Collaborator
There was a problem hiding this comment.
Can you follow this logging pattern?
Suggested change
| let err_msg = format!("Failed to send stop signal: {:?}", e); | |
| error!("{}", err_msg); | |
| error!( | |
| target: "managed_node", | |
| ?err, | |
| "Failed to send stop signal" | |
| ); |
itschaindev
commented
May 26, 2025
| let auth_header = | ||
| format!("Bearer {}", alloy_primitives::hex::encode(jwt_secret.as_bytes())); | ||
| headers.insert( | ||
| "Authorization", |
Collaborator
Author
There was a problem hiding this comment.
which crate are you referring to here?
dhyaniarun1993
approved these changes
May 26, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 26, 2025
Closes #1681 Things that are still left: - Call relevant DB functions on event notification - Check subscription with actual node - Fallback to HTTP polling using `PullEvents` if subscription does not work --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
Closes op-rs/kona#1681 Things that are still left: - Call relevant DB functions on event notification - Check subscription with actual node - Fallback to HTTP polling using `PullEvents` if subscription does not work --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
Closes #1681 Things that are still left: - Call relevant DB functions on event notification - Check subscription with actual node - Fallback to HTTP polling using `PullEvents` if subscription does not work --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1681
Things that are still left:
PullEventsif subscription does not work