This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(supervisor/storage): derivation schema#1808
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emhane
suggested changes
May 20, 2025
Comment on lines
+7
to
+9
| /// Wrapper for `Vec<u64>` to represent a list of numbers. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, Serialize, Deserialize, Compact)] | ||
| pub struct U64List(pub Vec<u64>); |
Contributor
There was a problem hiding this comment.
this type seems redundant, why do we need it?
Collaborator
Author
There was a problem hiding this comment.
Vec<u64> doesn't implement Compress and Decompress trait which is required by the table.
I will add a todo here to add support for Vec<u64>.
itschaindev
reviewed
May 20, 2025
Comment on lines
+7
to
+9
| /// Wrapper for `Vec<u64>` to represent a list of numbers. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, Serialize, Deserialize, Compact)] | ||
| pub struct U64List(pub Vec<u64>); |
sadiq1971
reviewed
May 20, 2025
itschaindev
approved these changes
May 20, 2025
emhane
approved these changes
May 21, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
Closes op-rs/kona#1749 --------- Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
Closes #1749 --------- Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1749
Ref #1684