Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(workspace): Exclude all crates except kona-common from cannon/asterisc lint job#168

Merged
refcell merged 1 commit intomainfrom
cl/bin-just-directives
Apr 28, 2024
Merged

chore(workspace): Exclude all crates except kona-common from cannon/asterisc lint job#168
refcell merged 1 commit intomainfrom
cl/bin-just-directives

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Apr 28, 2024

Optimizes the lint jobs by only including the crates with architecture-specific code (kona-common) in the lint-asterisc and lint-cannon recipes. All other crates have full lint coverage with the native lint recipe.

We still include all no_std crates in the build recipes for cannon / asterisc targets, as these crates still need build coverage to ensure that they always compile to our required targets.

…/asterisc lint job

Optimizes the lint jobs by only including the crates with
architecture-specific code (`kona-common`) in the `lint-asterisc` and
`lint-cannon` recipes. All other crates will be linted entirely with the
native lint recipe.

We still include all `no_std` crates in the `build` recipes for `cannon`
/ `asterisc` targets, as these crates still need build coverage to
ensure that they always compile to our required targets.
@clabby clabby self-assigned this Apr 28, 2024
Copy link
Contributor Author

clabby commented Apr 28, 2024

@clabby clabby added K-chore Kind: chore A-workspace Area: workspace level modifications labels Apr 28, 2024
@clabby clabby requested a review from refcell April 28, 2024 19:40
@refcell refcell added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit acbd292 Apr 28, 2024
@clabby clabby deleted the cl/bin-just-directives branch July 2, 2024 03:41
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
…/asterisc lint job (op-rs/kona#168)

Optimizes the lint jobs by only including the crates with
architecture-specific code (`kona-common`) in the `lint-asterisc` and
`lint-cannon` recipes. All other crates will be linted entirely with the
native lint recipe.

We still include all `no_std` crates in the `build` recipes for `cannon`
/ `asterisc` targets, as these crates still need build coverage to
ensure that they always compile to our required targets.
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
…/asterisc lint job (op-rs/kona#168)

Optimizes the lint jobs by only including the crates with
architecture-specific code (`kona-common`) in the `lint-asterisc` and
`lint-cannon` recipes. All other crates will be linted entirely with the
native lint recipe.

We still include all `no_std` crates in the `build` recipes for `cannon`
/ `asterisc` targets, as these crates still need build coverage to
ensure that they always compile to our required targets.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-workspace Area: workspace level modifications K-chore Kind: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants