Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(docker): Reproducible cannon prestate#1389

Merged
refcell merged 1 commit intomainfrom
cl/cannon-repro
Apr 8, 2025
Merged

feat(docker): Reproducible cannon prestate#1389
refcell merged 1 commit intomainfrom
cl/cannon-repro

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Apr 8, 2025

Overview

Adds a dockerfile for reproducible builds of the cannon prestate with kona-client.

Note that cannon does not yet support kona. ethereum-optimism/optimism#14454 must be merged before this can be used. This PR just adds the route to build the artifacts, but we will need to follow up with #1388 once the new instructions are supported and a new cannon tag has been released.

## Overview

Adds a dockerfile for reproducible builds of the `cannon` prestate with `kona-client`.

Note that `cannon` does not yet support `kona`. ethereum-optimism/optimism#14454 must be merged before this can be used. This PR just adds the route to build the artifacts, but we will need to follow up with <issue_num> once the new instructions are supported and a new `cannon` tag has been released.
@clabby clabby added K-feature Kind: feature A-workspace Area: workspace level modifications labels Apr 8, 2025
@clabby clabby self-assigned this Apr 8, 2025
Copilot AI review requested due to automatic review settings April 8, 2025 18:49
@clabby clabby requested review from emhane and refcell as code owners April 8, 2025 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • docker/docker-bake.hcl: Language not supported
  • docker/fpvm-prestates/cannon-repro.dockerfile: Language not supported
  • docker/fpvm-prestates/justfile: Language not supported
Comments suppressed due to low confidence (1)

docker/fpvm-prestates/README.md:14

  • [nitpick] Consider replacing the '+' sign with 'and' to improve clarity in the header.
### `kona-client` + `cannon` prestate artifacts

// You can override this if you'd like to use a different tag to generate the prestate.
// https://github.com/ethereum-optimism/optimism/releases
//
// NOTE: This version of cannon will not run `kona-client`. This is just a stub tag.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in #1388

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.9%. Comparing base (1d4c2fc) to head (eeeaf40).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clabby clabby added A-docker Area: Dockerfiles and removed A-workspace Area: workspace level modifications labels Apr 8, 2025
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@github-project-automation github-project-automation bot moved this to In Review in Project Tracking Apr 8, 2025
@refcell refcell added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 14bbb47 Apr 8, 2025
20 checks passed
@refcell refcell deleted the cl/cannon-repro branch April 8, 2025 19:38
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Apr 8, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-docker Area: Dockerfiles K-feature Kind: feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants