Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(host): Replace anyhow with thiserror#1093

Merged
refcell merged 2 commits intoop-rs:mainfrom
Levi0804:rm-anyhow-host
Mar 3, 2025
Merged

chore(host): Replace anyhow with thiserror#1093
refcell merged 2 commits intoop-rs:mainfrom
Levi0804:rm-anyhow-host

Conversation

@Levi0804
Copy link
Contributor

@Levi0804 Levi0804 commented Feb 23, 2025

This PR is a work in progress addressing #916.

I am aware that some of the changes in this PR introduce breaking changes in other parts of the workspace. I created this PR to take reviews on whether my approach looks good before proceeding further. Please let me know if these changes look good to you.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol style nit

@Levi0804
Copy link
Contributor Author

Will it be okay to allow unnameable_types in this case?

@Levi0804 Levi0804 changed the title Replace anyhow with thiserror chore(host): Replace anyhow with thiserror Feb 26, 2025
@refcell
Copy link
Contributor

refcell commented Feb 28, 2025

Few more comments for CI, otherwise this is looking good. Thanks for taking this on!

@Levi0804 Levi0804 force-pushed the rm-anyhow-host branch 3 times, most recently from 451de1e to bbf1aa0 Compare March 1, 2025 09:45
@Levi0804
Copy link
Contributor Author

Levi0804 commented Mar 1, 2025

Few more comments for CI, otherwise this is looking good. Thanks for taking this on!

Happy to contribute! Let me know if these changes look good. I squashed and rebased to clean up some mistakes...

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@refcell refcell requested a review from mattsse March 3, 2025 12:08
@Levi0804
Copy link
Contributor Author

Levi0804 commented Mar 3, 2025

Nice work!

Thanks! Should I squash and rewrite the commit message to focus on the changes?

@refcell refcell merged commit 5c41623 into op-rs:main Mar 3, 2025
13 of 17 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Mar 3, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants