Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(client): Remove Hardcoded Precompile Addresses#1013

Closed
refcell wants to merge 2 commits intomainfrom
rf/remove-hardcoded-addresses
Closed

chore(client): Remove Hardcoded Precompile Addresses#1013
refcell wants to merge 2 commits intomainfrom
rf/remove-hardcoded-addresses

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Feb 6, 2025

Description

Updates kona-client precompiles to use the addresses defined in revm-precompiles.

Reduces the chance that precompile addresses are incorrectly input.

@refcell refcell requested review from clabby and emhane as code owners February 6, 2025 17:15
@refcell refcell self-assigned this Feb 6, 2025
@refcell
Copy link
Contributor Author

refcell commented Feb 6, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Base automatically changed from rf/fix-de-dup-msm-required-fee-calc to main February 6, 2025 17:16
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.8%. Comparing base (183eefb) to head (de88987).
Report is 87 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@refcell
Copy link
Contributor Author

refcell commented Feb 6, 2025

Darn rust-analyzer must have automatically enabled blst feature... forgot bls12_381 module in revm is hidden behind blst. This is blocking. Once solution may be to PR into revm and try to hoist these constants to the parent module so they can be used without blst being enabled.

@refcell refcell marked this pull request as draft February 6, 2025 18:08
@refcell
Copy link
Contributor Author

refcell commented Feb 13, 2025

FYI - tracking this in revm here

@refcell refcell force-pushed the rf/remove-hardcoded-addresses branch from 219c593 to de88987 Compare February 26, 2025 00:05
@refcell
Copy link
Contributor Author

refcell commented Mar 11, 2025

Going to ice this for now since this will need to wait on revm.

@refcell refcell closed this Mar 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Project Tracking Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant