Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #222, Closes: #226, Closes: #229
Summary:
net35
andnet6.0
to stay compatible with older versions of dotnet.DocumentationFile
properties has been replaced withGenerateDocumentationFile
property.CodeAnalysisRuleSet
properties has been replaced with .NET Analyzers.Current issues
dotnet pack
command fails.nuget pack
command is not supported.I think package properties should be moved from ImageListView.nuspec to ImageListView.csproj (or alternatively Directory.Build.props) then pack it via
dotnet pack
ormsbuild -t:pack
.That being said, I'm not exactly sure how to include
WPFThumbnailExtractor.dll
into the package.Out of scope
Serving the documentations fails with the following error which can be solved by updating the
docfx.console
nuget package.