Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method to encode a Data URI (probably toString()) #3

Closed
ceefour opened this issue Nov 17, 2015 · 3 comments
Closed

Method to encode a Data URI (probably toString()) #3

ceefour opened this issue Nov 17, 2015 · 3 comments

Comments

@ceefour
Copy link

ceefour commented Nov 17, 2015

Although encoding a data URI is trivial, it's be nice if this is convenience method of DataURI (probably toString())
@ooxi
Copy link
Owner

ooxi commented Nov 17, 2015

This is so obvious, I wonder why I didn't already implement one o_O

Would you like to contribute a patch?

slomkowski added a commit to 1connect/jdatauri that referenced this issue Apr 3, 2016
@slomkowski
Implement toString() method. ooxi#3
3b02026
@slomkowski
Copy link
Contributor

@ceefour, I've implemented it in pull request #4.

ooxi pushed a commit that referenced this issue Apr 6, 2016
@slomkowski @ooxi
Implement toString() method. #3
3de03c5
@ooxi ooxi mentioned this issue Apr 6, 2016
Merged
ooxi added a commit that referenced this issue Apr 6, 2016
@ooxi
Merge pull request #7 from ooxi/feature/toString
a94faf5 
Merge toString implementation by Michał Słomkowski

Fixes issue #3, includes pull request #4
@ooxi
Copy link
Owner

ooxi commented Apr 6, 2016

Fixed by merging @slomkowski's implementation 3de03c5.

@ooxi ooxi closed this as completed Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ceefour @ooxi @slomkowski