prov/tcp: attempt to fix miltuthreaded progress #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooststep
force-pushed
the
tcp-cq-progress
branch
2 times, most recently
from
bd279ff
to
62184c6
Compare
|
The progress of CQs and counters can't be separated. They are often the same when bound to the same endpoint(s). We should consider the progress as a "completion object" that is associated with one or more CQs and/or counters and their bound endpoints. That makes it more complicated to assign progress to CQs and counters. One way to handle it is to assign progress to CQs or counters when they are bound to the endpoint, or when the endpoint is enabled. If conflict happens (more than one progress objects are related to one CQ, counter or endpoint), we have to revert to using a single progress object in the domain (can this be done safely?). The domain would maintain a list of progress objects so one can make progress for the entire domain. |
ooststep
force-pushed
the
tcp-cq-progress
branch
from
62184c6
to
f4a8905
Compare
ooststep
changed the title
ooststep
force-pushed
the
tcp-cq-progress
branch
from
f4a8905
to
99c6e48
Compare
having a single domain progress engine forces multi threaded applications to synchronize on the domain's progress lock instead, move progress to be owned by the ep (or srx)
we need to store the progress or have some way to reference back to the progress that the saved message belongs to
ofi_cq_progress and xnet_progress both attempt to lock the ep_list lock so we need to overwrite ofi_ep_bind_cq to use fid_list_insert with a NULL lock to avoid the deadlock
when closing an ep, we're already locking the ep list lock to circumvent attempting to lock again when unbinding from the cq, preempt the unbind without the lock to avoid it down the call stack
ooststep
force-pushed
the
tcp-cq-progress
branch
from
99c6e48
to
3a4a016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.