Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: deliver richer input to riseupvpn/openvpn #2600

Open
Tracked by #1291
bassosimone opened this issue Oct 23, 2023 · 0 comments
Open
Tracked by #1291

engine: deliver richer input to riseupvpn/openvpn #2600

bassosimone opened this issue Oct 23, 2023 · 0 comments
Assignees

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 23, 2023

Like #2606 but for riseupvpn/openvpn. (Main @ainghazal is already working on this though, in which case we should probably close this issue in favour of the issue that Ain is working on.)

@bassosimone bassosimone self-assigned this Oct 23, 2023
@bassosimone bassosimone changed the title engine: deliver richer input to riseupvpn engine: deliver richer input to riseupvpn/openvpn Jun 7, 2024
bassosimone added a commit to ooni/probe-cli that referenced this issue Jun 25, 2024
This commit:

1. modifies `./internal/registry` and its `openvpn.go` file such that
`openvpn` has its own private target loader;

2. modifies `./internal/experiment/openvpn` to use the richer input
targets to merge the options for the openvpn experiment.

3. removes cache from session after fetching openvpn config

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2600
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request
- [x] if you changed code inside an experiment, make sure you bump its
version number

---------

Co-authored-by: Simone Basso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant