Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archival: add tags to each fundamental data type #2483

Closed
bassosimone opened this issue May 26, 2023 · 0 comments · Fixed by ooni/probe-cli#1142
Closed

archival: add tags to each fundamental data type #2483

bassosimone opened this issue May 26, 2023 · 0 comments · Fixed by ooni/probe-cli#1142
Assignees
@bassosimone
Labels
data quality enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/high

Comments

@bassosimone
Copy link
Contributor

bassosimone commented May 26, 2023 •
edited
Loading

Richer input increases the number of cases where we want to precisely know why an observation has been generated. The current code base already uses tags for some data types for Web Connectivity v0.4. This issue is about extending all data types to include a Tags []string field that serializes to JSON as tags and extending measurexlite and dslx such that we can tag observations. This work will be part of ooni/ooni.org#1295 and ooni/ooni.org#1291.
@bassosimone bassosimone self-assigned this May 26, 2023
bassosimone added a commit to ooni/probe-cli that referenced this issue May 26, 2023
@bassosimone
feat(archival,dslx,measurexlite): tag all observations
715923b 
Closes ooni/probe#2483
This was referenced May 26, 2023
Merged
Merged
bassosimone added a commit to ooni/spec that referenced this issue May 26, 2023
@bassosimone
feat: define tags for all observations (#275)
74becbe 
See ooni/probe#2483 and ooni/probe-cli#1142.
bassosimone added a commit to ooni/probe-cli that referenced this issue May 26, 2023
@bassosimone
feat(archival,dslx,measurexlite): tag all observations (#1142)
f9c6bfe 
Closes ooni/probe#2483

While there, make sure we have 100% coverage in `dslx` and
`measurexlite`.

See ooni/spec#275.
@bassosimone bassosimone mentioned this issue Jul 21, 2023
Closed
cyBerta pushed a commit to cyBerta/probe-cli that referenced this issue Aug 4, 2023
@bassosimone @cyBerta
feat(archival,dslx,measurexlite): tag all observations (ooni#1142)
289fe8f 
Closes ooni/probe#2483

While there, make sure we have 100% coverage in `dslx` and
`measurexlite`.

See ooni/spec#275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
data quality enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(archival,dslx,measurexlite): tag all observations ooni/probe-cli
1 participant
@bassosimone