Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webconnectivitylte): add more tests and comments #1458

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jan 22, 2024

This diff ensures that we do not lose any comment or test that we removed in #1455 and rather aims to ensure we have equivalent tests and comments.

Part of ooni/probe#2652.

@bassosimone bassosimone marked this pull request as ready for review January 22, 2024 16:09
@bassosimone bassosimone requested a review from hellais as a code owner January 22, 2024 16:09
@bassosimone bassosimone changed the title x feat(webconnectivitylte): add more tests and comments Jan 22, 2024
@bassosimone bassosimone merged commit 0a5604a into master Jan 22, 2024
@bassosimone bassosimone deleted the issue/2652b branch January 22, 2024 16:13
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
This diff ensures that we do not lose any comment or test that we
removed in ooni#1455 and rather aims
to ensure we have equivalent tests and comments.

Part of ooni/probe#2652.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant