Skip to content

dynatemp_low, dynatemp_high, dynatemp_exponent parameters#5209

Merged
oobabooga merged 11 commits into
devfrom
dynatemp_new
Jan 9, 2024
Merged

dynatemp_low, dynatemp_high, dynatemp_exponent parameters#5209
oobabooga merged 11 commits into
devfrom
dynatemp_new

Conversation

@oobabooga
Copy link
Copy Markdown
Owner

@oobabooga oobabooga commented Jan 9, 2024

  • Removes dynamic_temperature_low parameter
  • Adds dynatemp_low, dynatemp_high, and dynatemp_exponent parameters
  • The new parameters are hidden if dynamic_temperature is unchecked, and become visible when it gets checked.

cc @BadisG @kalomaze

@BadisG
Copy link
Copy Markdown
Contributor

BadisG commented Jan 9, 2024

That looks good to me, I really like the dynamic_temperature tick that unhide the parameters, the average user will quickly understand what are the values to change for this specific sampler, thanks a lot!

@oobabooga oobabooga merged commit 29c2693 into dev Jan 9, 2024
@oobabooga oobabooga deleted the dynatemp_new branch January 9, 2024 02:48
@kalomaze
Copy link
Copy Markdown
Contributor

kalomaze commented Jan 9, 2024

For the sake of consistency, can we make it convert the min temp and max temp before it gets passed over to the API as a range value?

# Given temperatures in the UI
minTemp = 0.5
maxTemp = 1.5

# Calculate Temperature value (or Base temperature)
temperature_value = (minTemp + maxTemp) / 2

# Calculate Dynamic Temp Range
dynatemp_range = (maxTemp - minTemp) / 2

In koboldcpp (where it was merged first) it handles a dynatemp_range parameter. It would be best if the APIs matched in this regard.

@kalomaze
Copy link
Copy Markdown
Contributor

kalomaze commented Jan 9, 2024

Actually, we might as well leave it at that for now.

PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants