Gallery improvements#4789
Merged
Merged
Conversation
Owner
|
Those are excellent changes. Well done! |
Contributor
Author
|
Thanks for implementing! The filter feature may need a fix because event handling in Gradio seems to ignore consecutive events when one hasn't finished yet, resulting in unexpected results when you type fast. I believe this needs Gradio 4+ for it to be really fixed (see #1954. |
Owner
|
I tried upgrading to Gradio 4 some weeks ago and it basically broke everything. For now, a search feature that kind works is still better than no search feature at all. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Improvements:
gallery-items_per_pagesetting, allowing you to control the amount of items in the character gallery before Gradio starts to paginate them.gallery-opensetting, allowing you to open (expand) the character gallery by default.pfp_character_thumb.png?Jack>pfp_character_thumb.png?Jack_v2_Angry.Notes:
I was hoping to find a simpler way to fix updating the character pic, but I didn't want to create new/temp variables or anything like that and I didn't want unnecessary downloading by slapping on
?{time.time()}, so it is what it is. 🤩Videos:
(don't seem to embed)
Desktop.webm Android.webm