Allow for changing shared.settings during model load via API#4431
Closed
brthor wants to merge 1 commit intooobabooga:mainfrom
Closed
Allow for changing shared.settings during model load via API#4431brthor wants to merge 1 commit intooobabooga:mainfrom
brthor wants to merge 1 commit intooobabooga:mainfrom
Conversation
Owner
|
The current API will be replaced with an OpenAI-compatible one, and handling instruction templates is an open problem there. In particular, making |
Owner
|
Seems to be working for the OpenAI API: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Reasoning
Sometimes, when you load a certain lora, you need to be able to change the
instruction_templateon the fly.Rather than focus on that specific use case, allow for updating the
shared.settingsas a whole at the time of model load via the api.