Add more flexibility to "languages" flag #1111
Open
+74
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, the flag supports: - "default" to append the default set of languages, instead of overriding it entirely, e.g. --languages=default,tlh means all default languages *plus* Klingon. - "-lang" to exclude languages, e.g. --languages=default,-en means all default languages *except* English. - "*" to include all languages not specified. This can be combined with "-lang". e.g. --languages=*,-jbo means all languages *except* Lojban.
|
Full logs: https://github.com/onthegomap/planetiler/actions/runs/11999419714 |
|
Cool! Thanks for adding. Fixes #1043 |
msbarry
reviewed
Nov 25, 2024
| for (String language : languages) { | ||
| if (language.equals("*")) { |
There was a problem hiding this comment.
Minor but what about supporting "all" instead of or in addition to "*" so that you don't need to worry about bash expanding it as a wildcard?
There was a problem hiding this comment.
Good idea, but all is a language code assigned to https://en.wikipedia.org/wiki/Allar_language. Any better ideas for a keyword?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the flag supports: