Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves onsi/gomega#696: make HaveField great on pointer receivers… #802

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

thediveo
Copy link
Collaborator

@thediveo thediveo commented Dec 6, 2024

…given only a non-addressable value

  • don't reject pointer receivers on non-addressable values anymore; instead, create a pointer value to the original value and then lookup the pointer receiver method.
  • switches corresponding unit test from rejection to acceptance.

@thediveo thediveo requested a review from onsi December 6, 2024 19:40
@onsi onsi merged commit 4feb9d7 into onsi:master Dec 6, 2024
6 checks passed
@onsi
Copy link
Owner

onsi commented Dec 6, 2024

sweet! and thanks for tackling the various open issues! ❤️❤️❤️

@thediveo thediveo removed the request for review from onsi December 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants