Fix BeNilMatcher not matching nil pointers #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
BeNilMatcher
returnsfalse
for pointers that point to a nil value. Here is a code example that fails:This is because
actual
is used as aninterface{}
type inside theBeNilMatcher
. I have changed the implementation of it to, when theactual == nil
check fails, it uses reflection to get check ifactual
is a pointer and if so, it check the element value for nil.Here is the implementation: