Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispose to be similar to init (adding event) #184

Merged
merged 2 commits into from
Dec 28, 2019

Conversation

nicolasigot
Copy link
Contributor

Hello,

I have a use case in which I need to dispose metismenu on an element and recreate it later.
The issue is that the dispose does not off the click event on the same elements and same event as the init function.

This leads in error in console

image

The fix is to update the dispose to select the same elements and use the same event.

Thanks,
Nicolas

@onokumus onokumus merged commit e2f3c1e into onokumus:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants