Fix genai_config.json provider names to use short format - #247
Merged
Conversation
GenAI's NormalizeProviderName() expects short lowercase names
('cuda', 'dml', 'webgpu'), not the full ORT EP class names
('CUDAExecutionProvider', 'DmlExecutionProvider', etc.).
Update _ORT_PROVIDER_NAMES mapping and all tests.
118 ort_genai tests pass.
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Performance Comparison
|
Signed-off-by: Justin Chu <justinchu@microsoft.com>
apsonawane
approved these changes
May 4, 2026
justinchuby
enabled auto-merge (squash)
May 4, 2026 21:19
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix provider name format in generated genai_config.json to use short lowercase names that ORT GenAI expects.
Problem
mobius generated genai_config.json with full ORT EP class names (e.g.
CUDAExecutionProvider) inprovider_options, but GenAI'sNormalizeProviderName()expects short names (cuda,dml,webgpu).Fix
Updated
_ORT_PROVIDER_NAMESmapping inep_config.py:CUDAExecutionProvider→cudaDmlExecutionProvider→dmlWebGpuExecutionProvider→webgpuCPUExecutionProvider→cpuTesting
118 ort_genai tests pass.