Update comments in getting-started.md for clarity - #202
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Performance Comparison
|
There was a problem hiding this comment.
Pull request overview
Updates CLI example comments in the Getting Started guide to better describe the “default” and “onnx-standard” execution provider modes.
Changes:
- Refines the “Default”
mobius buildcomment to describe portability via local functions. - Shortens the “onnx-standard”
mobius buildcomment to focus on “zero custom ops”.
|
|
||
| ```bash | ||
| # Default (portable ONNX with standard fusions, no vendor-specific ops) | ||
| # Default (portable ONNX with standard fusions as model local functions) |
There was a problem hiding this comment.
The “Default” description here is potentially misleading: the default EP still applies fusions by emitting custom-domain ops (e.g., com.microsoft Skip* ops) with ONNX function bodies as a portable fallback. Consider rephrasing to explicitly mention “custom ops with ONNX function bodies/local functions” (or similar) so readers don’t interpret this as purely standard-ONNX nodes only.
| # Default (portable ONNX with standard fusions as model local functions) | |
| # Default (portable ONNX using custom fused ops with ONNX function bodies/local functions) |
| mobius build --model meta-llama/Llama-3.2-1B output/ --ep webgpu --dtype f16 | ||
|
|
||
| # Strict ONNX standard (zero custom ops, runs on any ONNX runtime) | ||
| # Strict ONNX standard (zero custom ops) |
There was a problem hiding this comment.
This “onnx-standard” description drops the key user-facing implication that the output should run on any conformant ONNX runtime without ORT extensions (matching the behavior described in src/mobius/_execution_providers.py). Consider adding that qualifier back (instead of just “zero custom ops”) to keep the guidance actionable.
| # Strict ONNX standard (zero custom ops) | |
| # Strict ONNX standard (runs on conformant ONNX runtimes without ORT | |
| # extensions; zero custom ops) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
No description provided.