Merge L3 parity status into L3 summary card in dashboard - #187
Merged
Conversation
Performance Comparison
|
Move the pass/xfail/skip breakdown from a separate card into the L3 level card as an annotation, consistent with L4/L5 cards that show skipped/awaiting-data counts inline. This change was lost in PR #183 when a later commit on the branch accidentally reverted the dashboard template. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
force-pushed
the
justinchu/dashboard-l3-card
branch
from
April 22, 2026 04:11
7c93002 to
cb2aea6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dashboard summary bar to inline the L3 parity (pass/xfail/skip) breakdown directly on the L3 level card, removing the previously separate “L3 Parity Status” card to reduce redundancy and align with the inline L4/L5 annotations.
Changes:
- Add an inline annotation on the L3 summary card showing pass/xfail/skip counts.
- Remove the standalone “L3 parity status breakdown” summary card.
- Update the surrounding summary-bar comment to reflect the new inline annotation behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the pass/xfail/skip breakdown from a separate card into the L3 level card as an annotation, consistent with L4/L5 cards that show skipped/awaiting-data counts inline.
This change was made in commit d0e6d49 on the
justinchu/generate-golden-databranch but was accidentally reverted by a later commit (2fb6b80) that overwrote the dashboard template from a stale working copy. The squash merge in PR #183 faithfully reflected the branch tip, which had already lost the change.Only file changed:
scripts/templates/dashboard.html.j2(+11, -15)