Fix Windows PermissionError in test_patch_merger - #160
Merged
Conversation
Replace tempfile-based ONNX save/load with in-memory protobuf serialization to avoid Windows concurrent file access errors. Use ir.serde.serialize_model() + SerializeToString() to load the model directly into ORT InferenceSession without disk I/O. Closes #159 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Performance Comparison
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows CI failure in test_patch_merger_matches_hf_unfold_ordering by avoiding NamedTemporaryFile() + ir.save() (which can trigger PermissionError due to file-handle locking on Windows) when creating an ORT InferenceSession.
Changes:
- Remove
tempfile.NamedTemporaryFile()roundtrip used to save/load a temporary ONNX file. - Build the ORT session from an in-memory serialized model instead of writing to disk.
|
The author of this PR, titaiwangms, is not an activated member of this organization on Codecov. |
🏗️ Architecture Diff
No architecture changes detected. ✅ Legend: ⚪ No change · 🔵 Minor (attrs/inits) · 🟡 Moderate (nodes added/removed) · 🔴 Major (interface changed) |
justinchuby
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace tempfile-based ONNX save/load with in-memory protobuf serialization to avoid Windows concurrent file access errors.
test_patch_merger_matches_hf_unfold_orderingin_pixtral_vision_test.pyfails on Windows CI becausetempfile.NamedTemporaryFile()keeps the file handle open whileir.save()tries to write to the same path.Fix: Use
ir.serde.serialize_model() + SerializeToString()to load the model directly into ORT InferenceSession without any disk I/O.Closes #159