ci: add codecov upload step to all CI pipelines - #135
Merged
Conversation
Add coverage collection (--cov=src --cov-report=xml --cov-branch) and
codecov upload steps to all test jobs across the CI pipeline:
- main.yml: smoke-test (flags: smoke), synthetic-parity (flags: synthetic-parity),
golden-comparison (flags: golden), test (flags: unittests),
integration-fast (flags: integration)
- gpu_tests.yml: golden-tests (flags: gpu, gpu-l4, gpu-l5)
- nightly_l2.yml: arch-validation (flags: arch-validation)
Each test job uploads both coverage (coverage.xml) and test results
(junit XML) to Codecov using `codecov/codecov-action@v6`, matching the
pattern used in onnx/ir-py. Token is read from ${{ secrets.CODECOV_TOKEN }}.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Performance Comparison
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pytest coverage collection and Codecov uploads (coverage + test results) across all CI workflows/jobs, following a shared pattern.
Changes:
- Added
--cov=src --cov-report=xml --cov-branch(and JUnit output where needed) to multiple pytest invocations. - Added
codecov/codecov-action@v6steps to upload coverage andreport-type: test_resultsto upload JUnit results across workflows. - Combined GPU L4/L5 coverage via
--cov-appendand uploaded L4/L5 JUnit results separately.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/main.yml |
Adds coverage + Codecov upload steps to smoke, synthetic parity, golden comparison, unit tests, and integration-fast jobs. |
.github/workflows/gpu_tests.yml |
Adds coverage collection for L4/L5 GPU golden tests and uploads combined coverage + per-suite JUnit results to Codecov. |
.github/workflows/nightly_l2.yml |
Adds coverage collection and Codecov uploads to nightly L2 architecture validation job. |
When golden test data is absent, the test step is skipped, leaving no coverage.xml or golden-results.xml. The codecov upload steps now use the same `steps.check_golden.outputs.has_golden == 'true'` guard as the test step so they are skipped rather than failing or uploading nothing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added a commit
that referenced
this pull request
Apr 9, 2026
## Summary Adds coverage collection and Codecov upload steps to all test jobs across the CI pipeline, matching the pattern from [onnx/ir-py](https://github.com/onnx/ir-py/blob/5291b8bb0b7104e9034dda6b9be9d43baf0d70ad/.github/workflows/main.yml#L64-L74). ## Changes ### `main.yml` | Job | Flag | Notes | |-----|------|-------| | `smoke-test` | `smoke` | Added `--cov` to pytest | | `synthetic-parity` | `synthetic-parity` | Added `--cov` to both pytest invocations | | `golden-comparison` | `golden` | Added `--cov` to pytest | | `test` | `unittests` | Already had `--cov`; added upload steps | | `integration-fast` | `integration` | Added `--cov` to pytest | ### `gpu_tests.yml` | Job | Flag | Notes | |-----|------|-------| | `golden-tests` (L4) | `gpu-l4` | Added `--cov` to L4 pytest | | `golden-tests` (L5) | `gpu-l5` | Added `--cov --cov-append` to L5 pytest; combined coverage upload with `gpu` flag | ### `nightly_l2.yml` | Job | Flag | Notes | |-----|------|-------| | `arch-validation` | `arch-validation` | Added `--cov` to pytest | ## Pattern used Each job now uploads both: 1. **Coverage** (`coverage.xml`) using `codecov/codecov-action@v6` with `if: always()` Token: `${{ secrets.CODECOV_TOKEN }}` (set as a repo secret for private repos; tokenless upload works for public repos). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coverage collection and Codecov upload steps to all test jobs across the CI pipeline, matching the pattern from onnx/ir-py.
Changes
main.ymlsmoke-testsmoke--covto pytestsynthetic-paritysynthetic-parity--covto both pytest invocationsgolden-comparisongolden--covto pytesttestunittests--cov; added upload stepsintegration-fastintegration--covto pytestgpu_tests.ymlgolden-tests(L4)gpu-l4--covto L4 pytestgolden-tests(L5)gpu-l5--cov --cov-appendto L5 pytest; combined coverage upload withgpuflagnightly_l2.ymlarch-validationarch-validation--covto pytestPattern used
Each job now uploads both:
coverage.xml) usingcodecov/codecov-action@v6withif: always()Token:
${{ secrets.CODECOV_TOKEN }}(set as a repo secret for private repos; tokenless upload works for public repos).Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com