Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add converter for QuantileTransformer #705

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Aug 20, 2021

No description provided.

@xadupre xadupre changed the title [WIP] Add QuantileTransformer [WIP] Add converter for QuantileTransformer Aug 20, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request introduces 1 alert when merging 1372d8b into 18d367d - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@xadupre xadupre added this to In progress in Summer 2021 Aug 20, 2021
@xadupre xadupre added the WOE label Aug 27, 2021
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2021

This pull request introduces 1 alert when merging dc29fee into c503962 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Signed-off-by: xadupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
model_onnx = convert_sklearn(
model, "test", [("input", FloatTensorType([None, X.shape[1]]))]
)
self.assertTrue(model_onnx is not None)

Check notice

Code scanning / CodeQL

Imprecise assert Note test

assertTrue(a is not b) cannot provide an informative message. Using assertIsNot(a, b) instead will give more informative messages.
# opv = container.target_opset
dtype = guess_numpy_type(operator.inputs[0].type)
if dtype != np.float64:
dtype = np.float32

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable dtype is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Summer 2021
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants