Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkg name of onnxconverter_common #683

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix pkg name of onnxconverter_common #683

merged 2 commits into from
Apr 2, 2024

Conversation

xkszltl
Copy link
Contributor

@xkszltl xkszltl commented Feb 23, 2024 •
edited
Loading

  • The pkg is dashed while the lib is underscored.
  • Add it to the dev requirements.

Resolve #673

@xkszltl
Fix pkg name of onnxconverter_common
2db3684 
The pkg is dashed while the lib is underscored

Signed-off-by: xkszltl <[email protected]>
@xkszltl
Update requirements-dev.txt
96f3a87 
Signed-off-by: xkszltl <[email protected]>
@xkszltl xkszltl mentioned this pull request Feb 23, 2024
Closed
@xadupre xadupre merged commit b788999 into onnx:main Apr 2, 2024
15 checks passed
@xkszltl xkszltl deleted the dash branch April 2, 2024 12:44
@XiangRongLin
Copy link

Am I seeing correctly that although the fix is merged, no release was created yet? Because I still encounter this issue when upgrading to 1.12.0

@xkszltl
Copy link
Contributor Author

xkszltl commented Apr 22, 2024

You may want to push project owner for a patch release.

@xkszltl
Copy link
Contributor Author

xkszltl commented Apr 22, 2024

1.12.0 is from last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xadupre xadupre xadupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No module named 'onnxconverter_common'
3 participants
@xkszltl @XiangRongLin @xadupre