Skip to content

Conversation

@justinchuby
Copy link
Member

With sphinx versionchanged and versionadded directives

With sphinx versionchanged and versionadded directives

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby requested review from a team and titaiwangms as code owners June 23, 2025 15:26
@justinchuby justinchuby added module: docs merge on lgtm Reviewers can merge if PR looks good labels Jun 23, 2025
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.52%. Comparing base (b2ad020) to head (b57f1f4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files          38       38           
  Lines        4687     4687           
  Branches      957      957           
=======================================
  Hits         3493     3493           
  Misses        841      841           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby removed the merge on lgtm Reviewers can merge if PR looks good label Jun 23, 2025
@justinchuby justinchuby added the merge on lgtm Reviewers can merge if PR looks good label Jun 23, 2025
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From now on, we need to log whenever a new version is about to be released? Is there an instruction showing how should we maintain this?

@justinchuby
Copy link
Member Author

justinchuby commented Jun 23, 2025

From now on, we need to log whenever a new version is about to be released? Is there an instruction showing how should we maintain this?

I agree it would be a good practice to document important API changes. I can add a line in https://github.com/onnx/ir-py/wiki/Coding-style for now and move to CONTRIBUTIONS.md. Do you have any suggestions?

@justinchuby justinchuby merged commit 5e39c37 into main Jun 23, 2025
24 checks passed
@justinchuby justinchuby deleted the justinchu/version-added branch June 23, 2025 19:54
@titaiwangms
Copy link
Collaborator

From now on, we need to log whenever a new version is about to be released? Is there an instruction showing how should we maintain this?

I agree it would be a good practice to document important API changes. I can add a line in https://github.com/onnx/ir-py/wiki/Coding-style for now and move to CONTRIBUTIONS.md. Do you have any suggestions?

SG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge on lgtm Reviewers can merge if PR looks good module: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants